1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
phorge-phorge/webroot/rsrc/js
epriestley e1da1d86d6 Trim and URI encode symbol names before building URIs from them
Summary:
Fixes T13437. This URI construction was just missing URI encoding.

Also, trim the symbol because my test case ended up catching "#define\n" as symbol text.

Test Plan:
  - Configured a repository to have PHP symbols.
  - Touched a ".php" file with "#define" in it.
  - Diffed the change.
  - Command-clicked "#define" in the UI, in Safari/MacOS, to jump to the definition.
    - Before: taken to a nonsense page where "#define" became an anchor.
    - After: taken to symbol search for "#define".

Maniphest Tasks: T13437

Differential Revision: https://secure.phabricator.com/D20876
2019-10-29 09:48:42 -07:00
..
application Trim and URI encode symbol names before building URIs from them 2019-10-29 09:48:42 -07:00
core Allow a user to target "#anchor" by navigating to any prefix 2019-09-24 10:56:35 -07:00
phui When users confirm Duo MFA in the mobile app, live-update the UI 2019-02-15 14:38:15 -08:00
phuix When a dropdown menu would render in a way that hides it offscreen, try a different alignment 2019-04-09 14:12:30 -07:00