1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/repository/customfield
epriestley 8ded0927aa Recover gracefully from Conduit failure when building "Tags" field in commit mail
Summary:
Ref T9458. This is basically the same as D13319, but the "Tags" field didn't get covered in that change.

Specifically, the issue is:

  - We try to generate mail to a disabled user (later, we'll drop it without delivering it, but that filtering doesn't happen yet).
  - The disabled user doesn't have permission to use Conduit (or any other Conduit-related problem occurs).
  - We fail here, then retry generating the mail again later.

Instead, just degrade to not building the field and showing what went wrong.

Test Plan:
  - Pushed some commits, saw mail generate.
  - Added a fake exception to the field, saw the mail generate with an error message.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9458

Differential Revision: https://secure.phabricator.com/D14142
2015-09-22 13:03:29 -07:00
..
PhabricatorCommitBranchesField.php Fail gracefully on bad API call when building commit mail 2015-06-16 16:06:42 -07:00
PhabricatorCommitCustomField.php Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
PhabricatorCommitMergedCommitsField.php Improve UX for Diffusion mail fields 2015-05-25 07:18:48 -07:00
PhabricatorCommitRepositoryField.php Improve UX for Diffusion mail fields 2015-05-25 07:18:48 -07:00
PhabricatorCommitTagsField.php Recover gracefully from Conduit failure when building "Tags" field in commit mail 2015-09-22 13:03:29 -07:00