1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
phorge-phorge/src/applications/home
Andre Klapper f8ae17bb6a Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15296

Test Plan: Applied this change and Home page rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15296

Differential Revision: https://we.phorge.it/D25145
2023-05-01 15:37:56 +02:00
..
application Restore old Home mobile menu behavior, hide crumbs 2017-02-01 10:29:13 -08:00
constants Use a label for default home menu 2017-02-01 07:20:13 -08:00
controller Automatically build mobile menus from navigation, and clean up external ProfileMenu API 2019-04-02 15:17:44 -07:00
engine Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
menuitem Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
view Use real Dashboard Panels to render the default hard-coded homepage, not hacky fake panels 2019-03-27 15:21:36 -07:00