1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-07 21:31:02 +01:00
phorge-phorge/src/applications/notification
epriestley 8efdc4aabf Replace getPagingValue() with cursor methods
Summary:
Ref T7803. Prior to this change sequence, Query classes conflated paging values (the actual thing that goes in a "x > 3" clause) with cursor values (arbitrary identifiers which track where the user is in a result list).

Although the two can sometimes be the same, the vast majority of implementations are simpler and better when object IDs are used as cursors and paging values are derived from them.

The new stuff handles this in a consistent way, so we're free to separate getPagingValue() from paging. The new method is essentially getResultCursor().

This also implements getPageCursors(), which allows queries to return directional cursors. The inability to do this was a practical limitation blocking the implementation of T7803.

Test Plan:
  - Browsed a bunch of results and paged through queries.
  - Grepped for removed methods.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7803

Differential Revision: https://secure.phabricator.com/D12383
2015-04-13 11:58:38 -07:00
..
application Add FontIcon bridge to AppIcons 2015-01-24 23:43:01 -08:00
builder Minor, improve notification resiliance 2014-04-21 16:28:59 -07:00
client Force Aphlict server connections to HTTP 2015-02-18 07:07:26 -08:00
controller Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
feed Add a "Send Test Notification" button to make testing the server easier 2014-02-17 16:00:33 -08:00
query Replace getPagingValue() with cursor methods 2015-04-13 11:58:38 -07:00
setup Minor tidying of some Aphlict code 2015-01-20 06:37:15 +11:00
storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
view Rewrite Aphlict to use Websockets 2015-01-08 10:03:00 -08:00