mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 02:02:41 +01:00
8f2c426ff2
Summary: ajtrichards reported an error creating a brand new authorization. fixed that and generally made this flow work well Test Plan: - created a fresh test client -- noted "new=<PHID>" with appropriate highlighting - visited http://phabricator.dev/oauthserver/auth/?client_id=PHID-OASC-jwgdrqdpzomtxyg3q3yf&response_type=code&scope=offline_access -- clicked "cancel", verified result -- clicked "approve", verfied result - visited http://phabricator.dev/oauthserver/auth/?client_id=PHID-OASC-jwgdrqdpzomtxyg3q3yf&response_type=code&scope=whoami -- noted got the dialog -- noted that it had the union of desired and existing so user could update it properly! (NB - its up to the client to react to whatever specific scope(s) the user decides to grant) -- noted it actually updated when I hit "approve" Reviewers: epriestley, ajtrichards Reviewed By: epriestley CC: aran, epriestley Maniphest Tasks: T933 Differential Revision: https://secure.phabricator.com/D1775
123 lines
3.5 KiB
PHP
123 lines
3.5 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class PhabricatorOAuthServerScope {
|
|
|
|
const SCOPE_OFFLINE_ACCESS = 'offline_access';
|
|
const SCOPE_WHOAMI = 'whoami';
|
|
const SCOPE_NOT_ACCESSIBLE = 'not_accessible';
|
|
|
|
/*
|
|
* Note this does not contain SCOPE_NOT_ACCESSIBLE which is magic
|
|
* used to simplify code for data that is not currently accessible
|
|
* via OAuth.
|
|
*/
|
|
static public function getScopesDict() {
|
|
return array(
|
|
self::SCOPE_OFFLINE_ACCESS => 1,
|
|
self::SCOPE_WHOAMI => 1,
|
|
);
|
|
}
|
|
|
|
static public function getCheckboxControl($current_scopes) {
|
|
$scopes = self::getScopesDict();
|
|
$scope_keys = array_keys($scopes);
|
|
sort($scope_keys);
|
|
|
|
$checkboxes = new AphrontFormCheckboxControl();
|
|
foreach ($scope_keys as $scope) {
|
|
$checkboxes->addCheckbox(
|
|
$name = $scope,
|
|
$value = 1,
|
|
$label = self::getCheckboxLabel($scope),
|
|
$checked = isset($current_scopes[$scope])
|
|
);
|
|
}
|
|
$checkboxes->setLabel('Scope');
|
|
|
|
return $checkboxes;
|
|
}
|
|
|
|
static private function getCheckboxLabel($scope) {
|
|
$label = null;
|
|
switch ($scope) {
|
|
case self::SCOPE_OFFLINE_ACCESS:
|
|
$label = 'Make access tokens granted to this client never expire.';
|
|
break;
|
|
case self::SCOPE_WHOAMI:
|
|
$label = 'Read access to Conduit method user.whoami.';
|
|
break;
|
|
}
|
|
|
|
return $label;
|
|
}
|
|
|
|
static public function getScopesFromRequest(AphrontRequest $request) {
|
|
$scopes = self::getScopesDict();
|
|
$requested_scopes = array();
|
|
foreach ($scopes as $scope => $bit) {
|
|
if ($request->getBool($scope)) {
|
|
$requested_scopes[$scope] = 1;
|
|
}
|
|
}
|
|
return $requested_scopes;
|
|
}
|
|
|
|
/**
|
|
* A scopes list is considered valid if each scope is a known scope
|
|
* and each scope is seen only once. Otherwise, the list is invalid.
|
|
*/
|
|
static public function validateScopesList($scope_list) {
|
|
$scopes = explode(' ', $scope_list);
|
|
$known_scopes = self::getScopesDict();
|
|
$seen_scopes = array();
|
|
foreach ($scopes as $scope) {
|
|
if (!isset($known_scopes[$scope])) {
|
|
return false;
|
|
}
|
|
if (isset($seen_scopes[$scope])) {
|
|
return false;
|
|
}
|
|
$seen_scopes[$scope] = 1;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* A scopes dictionary is considered valid if each key is a known scope.
|
|
* Otherwise, the dictionary is invalid.
|
|
*/
|
|
static public function validateScopesDict($scope_dict) {
|
|
$known_scopes = self::getScopesDict();
|
|
$unknown_scopes = array_diff_key($scope_dict,
|
|
$known_scopes);
|
|
return empty($unknown_scopes);
|
|
}
|
|
|
|
/**
|
|
* Transforms a space-delimited scopes list into a scopes dict. The list
|
|
* should be validated by @{method:validateScopesList} before
|
|
* transformation.
|
|
*/
|
|
static public function scopesListToDict($scope_list) {
|
|
$scopes = explode(' ', $scope_list);
|
|
return array_fill_keys($scopes, 1);
|
|
}
|
|
|
|
}
|