1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
phorge-phorge/src
Andre Klapper 8f669ea082 Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as
a general replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Use `phutil_nonempty_scalar()` instead in `PhabricatorSearchDateField.php` as
input could only be integer instead of string.

Closes T15297

Test Plan: Applied these four changes (on top of D25144, D25145, D25146) and `/people/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15297

Differential Revision: https://we.phorge.it/D25147
2023-05-01 22:31:28 +02:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront PHP 8.1 "preg_match(null)" exception in javelin/markup.php when http_action not set 2023-04-25 15:45:57 +02:00
applications Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page 2023-05-01 22:31:28 +02:00
docs Update "how to file bugs" 2023-04-18 08:21:33 -07:00
extensions
infrastructure Fix PHP 8.1 "strlen(null)" exception which blocks rendering user's Edit Profile page 2023-05-01 22:05:37 +02:00
view Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page 2023-05-01 22:31:28 +02:00
__phutil_library_init__.php Rebrand: Rename library and update "version" logic 2022-08-25 01:26:21 -07:00
__phutil_library_map__.php Countdown: fix PhutilMissingSymbolException 2023-04-25 06:37:38 -07:00