1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 02:02:41 +01:00
phorge-phorge/src/applications/diffusion/controller
epriestley 900190b2fe Add inline comments to Diffusion/Audit
Summary:
  - Add inline comments to Audits, like Differential.
  - Creates new storage for the comments in the Audits database.
  - Creates a new PhabricatorAuditInlineComment class, similar to DifferentialInlineComment.
  - Defines an Interface which Differential and Audit comments conform to.
  - Makes consumers of DifferentialInlineComments consume objects which implement that interface instead.
  - Adds save

NOTE: Some features are still missing! Wanted to cut this off before it got crazy:

  - Inline comments aren't shown in the main comment list.
  - Inline comments aren't shown in the emails.
  - Inline comments aren't previewed.

I'll followup with those but this was getting pretty big.

@vrana, does the SQL change look correct?

Test Plan:
  - Created, edited, deleted, replied to, reloaded and saved inline comments in Diffusion, on the left and right side of diffs.
  - Created, edited, deleted, replied to, reloaded and saved inline comments in Differentila, on the left and right side of primary and diff-versus-diff diffs.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T904

Differential Revision: https://secure.phabricator.com/D1898
2012-03-14 12:56:01 -07:00
..
base [diffusion] Fix pending differential revisions list 2012-02-21 22:47:36 -08:00
browse Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
change Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
commit Add inline comments to Diffusion/Audit 2012-03-14 12:56:01 -07:00
diff Add inline comments to Diffusion/Audit 2012-03-14 12:56:01 -07:00
file Unmisplace edit button in Diffusion 2012-03-14 09:57:57 -07:00
history Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
home Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
inline Add inline comments to Diffusion/Audit 2012-03-14 12:56:01 -07:00
lastmodified Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
pathcomplete Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
pathvalidate Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
repository Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
symbol Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00