1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/src/view
epriestley 90258ed491 Fix property shadowing on ActionListView after conversion to TagView
Summary:
See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an `id` property, and this new `id` property on the subclass shadows it.

Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views.

Test Plan:
  - Viewed a task.
  - Made browser window narrow.
  - Clicked `[= Actions]` button.
  - After patch: saw a dropdown menu.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17223
2017-01-18 13:14:24 -08:00
..
__tests__ Fix local time test case for logged-out viewers using global settings 2016-11-28 09:27:11 -08:00
control Redesign Application Search 2016-08-01 12:23:36 -07:00
extension Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
form Allow any EditEngine comment form to be pinned 2016-12-29 12:49:18 -08:00
layout Fix property shadowing on ActionListView after conversion to TagView 2017-01-18 13:14:24 -08:00
page Make documentation items in user menu update as you navigate in Quicksand 2017-01-17 15:55:52 -08:00
phui Make documentation items in user menu update as you navigate in Quicksand 2017-01-17 15:55:52 -08:00
widget Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
AphrontDialogView.php Allow dialogs to opt in to being resizable 2016-06-20 19:13:58 -07:00
AphrontJavelinView.php Various linter fixes 2015-05-20 07:27:41 +10:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode 2017-01-09 08:41:59 -08:00
AphrontView.php Give AphrontTagView a getViewer(), deprecate getUser() 2016-03-06 09:27:38 -08:00
viewutils.php Continue modernizing application access to user preferences 2016-06-04 14:37:56 -07:00