mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-24 14:30:56 +01:00
90258ed491
Summary: See D17222. D17209 accidentally broke setting IDs on ActionListView by converting it into a TagView: TagView already has an `id` property, and this new `id` property on the subclass shadows it. Materially, the "Actions" mobile button in the headers of objects (for example: Maniphest Task -> shrink browser window -> click "Actions" next to task name) relies on setting IDs on list views. Test Plan: - Viewed a task. - Made browser window narrow. - Clicked `[= Actions]` button. - After patch: saw a dropdown menu. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D17223 |
||
---|---|---|
.. | ||
__tests__ | ||
control | ||
extension | ||
form | ||
layout | ||
page | ||
phui | ||
widget | ||
AphrontDialogView.php | ||
AphrontJavelinView.php | ||
AphrontNullView.php | ||
AphrontTagView.php | ||
AphrontView.php | ||
viewutils.php |