1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 06:50:55 +01:00
phorge-phorge/src
Bob Trahan 905fc217b8 Phriction - validateTransactions that need parent ancestry to complete successfully
Summary:
Fixes T6651, T6682. Since policy is defined by ancestry, you can't make things outside the core tree.

An alternative fix would be to automagically stub everything in these cases. This has potential negative policy implications - consider making a public document with several levels of depth that automagically stubs out its ancestry as public - and additionally the PhabricatorApplicationTransactionEditor framework would make this very tricky code (i.e. you are expected to validateTransactions in said hook *and* return an error if things aren't valid and not do some automagic stubbing, etc.)

Test Plan: tried to move a doc from location/that/exists to locationz/thatz/dontz/existz/ and got an error message with links to each missing doc. tried to create a doc at locatonz/thatz/dontz/existsz/ and got an error message with links to each missing doc.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6682, T6651

Differential Revision: https://secure.phabricator.com/D10978
2014-12-12 11:35:43 -08:00
..
__tests__ Remove UTF8 BMP unit test and replace it with a general UTF8 test 2014-10-02 11:47:25 -07:00
aphront Make ConduitCall always local/in-process 2014-12-10 15:27:07 -08:00
applications Phriction - validateTransactions that need parent ancestry to complete successfully 2014-12-12 11:35:43 -08:00
docs Fixed typo in Phame user guide 2014-11-26 05:07:43 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure When a worker task fails permanently, log the reason 2014-12-08 11:27:10 -08:00
view Transactions - make quotes work for older transactions 2014-12-11 10:27:28 -08:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Maniphest - use subscribers framework properly 2014-12-10 16:27:30 -08:00