1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
phorge-phorge/src/infrastructure
epriestley 9292433dae Implement "Resign" action against ApplicationTransactions
Summary:
Ref T2222. This introduces two small new concepts:

  - `expandTransactions()`: allows a transaction to expand into several transactions. For example, "resign" adds a "remove reviewers" transaction.
    - We have some other cases which could use this, but currently hard-code things outside of the `Editor`.
      - One example is that in Maniphest, closing a task implies claiming it if it is unowned.
  - `setIgnoreOnNoEffect()`: The whole Editor can be set to continue or stop if any transactions have no effect, but this allows the behavior to be refined at the individual transaction level. This is primarily to make the UX less confusing, so the user gets only a single relevant error instead of one for each expanded transaction.

Otherwise, this is pretty straightforward.

Test Plan:
Rigged comment form to use SavePro controller, enabled resign action, then tried to resign from a bunch of stuff.

{F117743}

Reviewers: btrahan

Reviewed By: btrahan

CC: chad, aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8328
2014-02-25 12:36:02 -08:00
..
__tests__ Convert Phabricator to handle "%s" / "%B" properly 2014-02-23 16:20:46 -08:00
celerity Automatically inline small images using data URIs 2014-02-13 17:39:47 -08:00
customfield Separate reading object values out of didSetObject() in CustomField 2014-02-21 14:44:01 -08:00
daemon Fix the What's New? phabricatorbot handler. 2014-02-01 17:18:44 -08:00
diff Make Differential inline comment rendering more consistent and somewhat more modern 2014-02-21 11:52:03 -08:00
edges Persist column membership after tasks are dragged around 2014-01-13 12:24:50 -08:00
env Put PATH in $_ENV after we adjust it so ExecFuture/etc pick it up 2013-11-27 21:03:00 -08:00
events Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
internationalization Implement "Resign" action against ApplicationTransactions 2014-02-25 12:36:02 -08:00
javelin Detect developer error when constructing forms with absolute URIs 2014-01-23 14:03:28 -08:00
lint Fix two bugs with DraggableList 2014-01-13 12:23:20 -08:00
log Add an SSH access log 2013-12-05 17:00:48 -08:00
management Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
markup Add ability to pass width arg to dot remarkup interpeter 2014-02-14 13:15:19 -08:00
query Fix an error in the PolicyFilter algorithm 2013-12-05 17:00:53 -08:00
ssh Fix an issue where SSH workflows would execute immediately 2013-12-27 15:18:03 -08:00
storage Convert Phabricator to handle "%s" / "%B" properly 2014-02-23 16:20:46 -08:00
testing Implement an approval queue 2013-11-13 11:24:56 -08:00
time Consolidate some datetime code and add unit tests 2013-06-03 12:58:11 -07:00
util Don't prompt to upgrade unset passwords 2014-02-20 08:12:04 -08:00
PhabricatorEditor.php Use ManiphestTaskQuery in nearly all interfaces 2013-09-25 13:44:14 -07:00