1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/webroot/rsrc/css
epriestley 9292433dae Implement "Resign" action against ApplicationTransactions
Summary:
Ref T2222. This introduces two small new concepts:

  - `expandTransactions()`: allows a transaction to expand into several transactions. For example, "resign" adds a "remove reviewers" transaction.
    - We have some other cases which could use this, but currently hard-code things outside of the `Editor`.
      - One example is that in Maniphest, closing a task implies claiming it if it is unowned.
  - `setIgnoreOnNoEffect()`: The whole Editor can be set to continue or stop if any transactions have no effect, but this allows the behavior to be refined at the individual transaction level. This is primarily to make the UX less confusing, so the user gets only a single relevant error instead of one for each expanded transaction.

Otherwise, this is pretty straightforward.

Test Plan:
Rigged comment form to use SavePro controller, enabled resign action, then tried to resign from a bunch of stuff.

{F117743}

Reviewers: btrahan

Reviewed By: btrahan

CC: chad, aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8328
2014-02-25 12:36:02 -08:00
..
aphront Implement "Resign" action against ApplicationTransactions 2014-02-25 12:36:02 -08:00
application Calendar upgrades 2014-02-24 10:04:23 -08:00
core PHUITimelineView 2014-02-12 09:02:05 -08:00
diviner PHUIPropertyListView 2013-10-11 07:53:56 -07:00
layout PHUITimelineView 2014-02-12 09:02:05 -08:00
phui Calendar upgrades 2014-02-24 10:04:23 -08:00
sprite-actions.css Add action icons to object list views 2013-05-10 12:57:01 -07:00
sprite-apps-large.css New icons for nav and dashboard 2014-01-30 16:23:06 -08:00
sprite-apps-xlarge.css Added Feed icons. 2013-01-10 10:00:18 -08:00
sprite-apps.css Add app icons to quick menu 2014-01-31 15:19:39 -08:00
sprite-buttonbar.css ProjectView improvements 2014-02-13 14:36:49 -08:00
sprite-conpherence.css Conpherence - some cleanup type stuff 2013-03-13 13:03:51 -07:00
sprite-docs.css Document icons sprite sheet. 2013-03-10 14:16:16 -07:00
sprite-gradient.css Add objectheaders to new View 2013-09-28 15:55:38 -07:00
sprite-icons.css ProjectView improvements 2014-02-13 14:36:49 -08:00
sprite-login.css Add Persona login icon 2013-10-14 16:33:49 -07:00
sprite-main-header.css Multicolor headers 2013-12-06 12:08:11 -08:00
sprite-menu.css Mobile "quick create" icons. 2013-07-28 13:47:09 -07:00
sprite-minicons.css PhabricatorActionHeaderView v0 2013-04-05 07:40:27 -07:00
sprite-payments.css Payment sprite icons. 2013-04-22 16:41:00 -07:00
sprite-projects.css Add an icon+background selector for project images 2013-10-17 09:32:34 -07:00
sprite-status.css Mail icon for email lists in typeahead 2014-02-17 10:06:16 -08:00
sprite-tokens.css Add Pebkac app icon, 2x Tokens 2013-11-04 11:50:19 -08:00