1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 09:58:24 +01:00
phorge-phorge/src
epriestley 930cc7a6dd Generalize Legalpad validation logic for "Require Signature"
Summary:
See downstream <https://phabricator.wikimedia.org/T208254>.

I can't actually reproduce any issue here (we only show this field when creating a document, and only if the viewer is an administrator), so maybe this relied on some changes or was originally reported against older code.

Regardless, the validation isn't quite right: it requires administrator privileges to apply this transaction at all, but should only require administrator privileges to change the value.

Test Plan:
Edited Legalpad documents as an administrator and non-administrator before and after the change, with and without signatures being required.

Couldn't reproduce the original issue, but this version is generally more correct/robust.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20311
2019-03-25 11:26:13 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Refine the "Mangled Webserver Response" setup check 2019-03-05 12:58:32 -08:00
applications Generalize Legalpad validation logic for "Require Signature" 2019-03-25 11:26:13 -07:00
docs Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers" 2019-03-16 12:35:55 -07:00
extensions
infrastructure When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank > ..." 2019-03-25 10:52:36 -07:00
view Remove the ability to drag tasks up and down on (non-Workboard) priority list views 2019-03-12 12:47:36 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer 2019-03-19 13:04:07 -07:00