mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-05 05:02:44 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
34 lines
795 B
PHP
34 lines
795 B
PHP
<?php
|
|
|
|
final class DiffusionCommitParentsQueryConduitAPIMethod
|
|
extends DiffusionQueryConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'diffusion.commitparentsquery';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht(
|
|
"Get the commit identifiers for a commit's parent or parents.");
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'list<string>';
|
|
}
|
|
|
|
protected function defineCustomParamTypes() {
|
|
return array(
|
|
'commit' => 'required string',
|
|
);
|
|
}
|
|
|
|
protected function getResult(ConduitAPIRequest $request) {
|
|
$repository = $this->getRepository($request);
|
|
|
|
return id(new DiffusionLowLevelParentsQuery())
|
|
->setRepository($repository)
|
|
->withIdentifier($request->getValue('commit'))
|
|
->execute();
|
|
}
|
|
|
|
}
|