1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/infrastructure
epriestley 9384c9e36b Don't consider integer CustomFields as changed when the number doesn't change
Summary: Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan:
{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Reviewers: btrahan, richardvanvelzen

Reviewed By: richardvanvelzen

CC: aran

Maniphest Tasks: T4466

Differential Revision: https://secure.phabricator.com/D8292
2014-02-21 08:59:31 -08:00
..
__tests__ In unit test environments, install all applications 2013-05-16 12:25:26 -07:00
celerity Automatically inline small images using data URIs 2014-02-13 17:39:47 -08:00
customfield Don't consider integer CustomFields as changed when the number doesn't change 2014-02-21 08:59:31 -08:00
daemon Fix the What's New? phabricatorbot handler. 2014-02-01 17:18:44 -08:00
diff Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
edges Persist column membership after tasks are dragged around 2014-01-13 12:24:50 -08:00
env Put PATH in $_ENV after we adjust it so ExecFuture/etc pick it up 2013-11-27 21:03:00 -08:00
events Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
internationalization Hide seen transactions by default in all modern applications 2014-02-14 10:23:07 -08:00
javelin Detect developer error when constructing forms with absolute URIs 2014-01-23 14:03:28 -08:00
lint Fix two bugs with DraggableList 2014-01-13 12:23:20 -08:00
log Add an SSH access log 2013-12-05 17:00:48 -08:00
management Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
markup Add ability to pass width arg to dot remarkup interpeter 2014-02-14 13:15:19 -08:00
query Fix an error in the PolicyFilter algorithm 2013-12-05 17:00:53 -08:00
ssh Fix an issue where SSH workflows would execute immediately 2013-12-27 15:18:03 -08:00
storage Rename PhabricatorUserStatus to PhabricatorCalendarEvent 2014-02-06 10:07:29 -08:00
testing Implement an approval queue 2013-11-13 11:24:56 -08:00
time Consolidate some datetime code and add unit tests 2013-06-03 12:58:11 -07:00
util Don't prompt to upgrade unset passwords 2014-02-20 08:12:04 -08:00
PhabricatorEditor.php Use ManiphestTaskQuery in nearly all interfaces 2013-09-25 13:44:14 -07:00