1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications/diffusion
epriestley 156b156e77 Give Conduit params/return/errors protected visibility
Summary:
Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan:
  - Ran `arc unit --everything`.
  - Called `conduit.query`.
  - Browsed Conduit UI.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T5873, T7803

Differential Revision: https://secure.phabricator.com/D12380
2015-04-13 11:58:35 -07:00
..
application Expose all application mail receivers 2015-04-01 11:52:02 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
config Remove all application-specific reply handler class overrides 2015-03-31 17:22:01 -07:00
controller Remove ORDER_PATH_MODIFIED from Differential 2015-04-13 11:58:26 -07:00
data Fix text lint issues 2015-02-12 07:00:13 +11:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Use PhabricatorAuditEditor to write revert edges 2015-01-06 07:30:38 +11:00
engine Attach HeraldRules to HeraldEffects 2015-04-06 10:00:45 -07:00
events Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
herald Lift handling of Herald "email" effect to Adapter 2015-04-06 10:00:35 -07:00
panel Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
protocol Applied various linter fixes. 2014-06-09 16:04:12 -07:00
query Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
remarkup make repo callsigns optional 2015-01-01 08:07:26 -08:00
request Fix lookup of commits in Subversion 2015-02-03 09:54:17 -08:00
response Allow Phabricator to serve Mercurial repositories over HTTP 2013-11-06 18:00:42 -08:00
ssh Fix directory moves and copies in Subversion hosted repositories 2015-03-26 11:13:41 -07:00
typeahead Policy - lock down DiffusionSymbolQuery repo-loading code 2015-01-31 18:36:36 -08:00
view Send Markdown in Diffusion through SourceSans 2015-04-08 09:41:56 -07:00
DiffusionLintSaveRunner.php Remove 'initFromConduit' option from Diffusion 2015-01-23 13:31:45 -08:00