1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/slowvote/storage
epriestley 943c62d1e9 Add missing expected keys and uniqueness
Summary:
Ref T1191.

  - Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
  - Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
  - Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):

{F210089}

  - Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):

{F210090}

Test Plan:
  - Vetted missing/surplus/unique messages.
  - 146 issues remaining.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10590
2014-10-01 07:53:50 -07:00
..
PhabricatorSlowvoteChoice.php Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
PhabricatorSlowvoteDAO.php Remove @group annotations 2014-07-10 08:12:48 +10:00
PhabricatorSlowvoteOption.php Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
PhabricatorSlowvotePoll.php Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
PhabricatorSlowvoteSchemaSpec.php Generate expected schemata for Workers, XHProf, PHPAAST, Tokens, System, Slowvote 2014-09-19 05:45:24 -07:00
PhabricatorSlowvoteTransaction.php Rename PHIDType classes 2014-07-24 08:05:46 +10:00
PhabricatorSlowvoteTransactionComment.php Various linter fixes. 2014-02-26 12:44:58 -08:00