revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-25 13:09:08 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/project
History
epriestley c42c5983aa Fix an issue where loading a mangled project graph could fail too abruptly 
Summary:
Ref T13484. If you load a subproject S which has a mangled/invalid `parentPath`, the query currently tries to execute an empty edge query and fatals.

Instead, we want to deny-by-default in the policy layer but not fail the query. The subproject should become restricted but not fatal anything related to it.

See T13484 for a future refinement where we could identify "broken / data integrity issue" objects explicilty.

Test Plan:
  - Modified the `projectPath` of some subproject in the database to `QQQQ...`.
  - Loaded that project page.
  - Before patch: fatal after issuing bad edge query.
  - After patch: "functionally correct" policy layer failure, although an explicit "data integrity issue" failure would be better.

Maniphest Tasks: T13484

Differential Revision: https://secure.phabricator.com/D20963
2020-02-03 08:54:04 -08:00
..
__tests__ When predicting object policies for project milestones, adjust objects so they behave like milestones 2019-11-18 23:06:03 -08:00
application Make pressing "R" on your keyboard reload the card state on workboards 2019-07-17 13:11:26 -07:00
capability Add default View, Edit, and Join Policies to Projects 2014-11-21 11:22:17 -08:00
chart Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not total tasks 2019-10-29 13:48:43 -07:00
command Implement a "!projects" mail command 2015-04-01 11:51:51 -07:00
conduit Migrate Project color to modular transactions 2017-05-18 16:46:06 -07:00
config Support subtypes in Projects 2019-01-30 06:17:55 -08:00
constants Allow workboard background colors to be configured 2016-02-16 08:15:12 -08:00
controller Improve project member list behaviors related to disabled users 2019-10-24 18:41:33 -07:00
customfield Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
edge Replace subscribe/unsubscribe for projects with explicit mail setting 2016-01-19 19:39:02 -08:00
editor When predicting project membership during edits, predict milestones will have parent membership 2019-11-18 23:07:05 -08:00
engine Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project 2019-10-17 09:49:01 -07:00
engineextension On workboards, link ancestor project breadcrumbs to their workboards 2019-03-27 14:42:57 -07:00
events On workboards, link ancestor project breadcrumbs to their workboards 2019-03-27 14:42:57 -07:00
exception Hard code a "close task" action on every column Trigger 2019-03-25 13:21:55 -07:00
herald Add "Project tags added" and "Project tags removed" fields in Herald 2020-01-22 18:20:57 -08:00
icon When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip 2019-03-25 14:02:10 -07:00
interface Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project 2019-10-17 09:49:01 -07:00
lipsum Migrate Project status to modular transactions 2017-05-18 11:36:13 -07:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
menuitem Unprototype "Facts" to clear Maniphest/chart fatals 2019-09-23 13:01:18 -07:00
order Don't show workboard action previews if the action won't have any effect 2019-03-25 13:24:01 -07:00
phid On workboards, link ancestor project breadcrumbs to their workboards 2019-03-27 14:42:57 -07:00
policyrule Add a "members of all projects" (vs "...any project") custom policy rule to the upstream 2018-06-12 11:51:51 -07:00
query Fix an issue where loading a mangled project graph could fail too abruptly 2020-02-03 08:54:04 -08:00
remarkup Fix spelling 2017-10-09 10:48:04 -07:00
search Support Ferret engine in Projects 2017-09-07 13:24:23 -07:00
searchfield Fix a bad call when prefilling ApplicationSearch from ?projects=some_slug 2016-02-08 10:44:33 -08:00
state Fix URI escaping, which should actually be "%s", not "%p" 2019-07-04 11:00:04 -07:00
storage When predicting object policies for project milestones, adjust objects so they behave like milestones 2019-11-18 23:06:03 -08:00
trigger Distinguish between "bad record format" and "bad record value" when validating Trigger rules 2019-04-17 12:40:55 -07:00
typeahead Support subtypes in Projects 2019-01-30 06:17:55 -08:00
view Improve project member list behaviors related to disabled users 2019-10-24 18:41:33 -07:00
xaction Don't warn that workboard columns need a name when editing milestone columns 2019-04-18 13:13:10 -07:00