1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 17:28:51 +02:00
phorge-phorge/webroot/rsrc/js/core
epriestley 94c29007b6 Generalize rules for "workflow" sigil
Summary:
See discussion in D6130. Basically, all of these should activate workflow:

  <a data-sigil="workflow" href="...">...</a>

  <div data-sigil="workflow">
    <a href="...">...</a>
  </div>

  <form data-sigil="workflow" action="...">...</form>

  <div data-sigil="workflow">
    <form action="...">...</form>
  </div>

The only case where we don't want to activate workflow is this one:

  <form data-sigil="workflow">
    <a href="...">...</a>
  </form>

Here, the form should workflow but the `<a />` should not.

These cases aren't really covered:

  // Undefined no matter where "workflow" is because it's nonsense.
  <a><a>...</a></a>

  // As above except like a million times more dumb.
  <form><form>...</form></form>

  // This one is ambiguous. The <a /> will currently workflow. We don't do
  // this anywhere and probably never will. If we want a different rule we
  // can cross that bridge when we come to it.
  <div data-sigil="workflow">
    <form action="...">
      <a href="...">...</a>
    </form>
  </div>

Test Plan: Clicked/submitted some things with workflow.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6131
2013-06-05 16:21:21 -07:00
..
behavior-active-nav.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-autofocus.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-crop.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-dark-console.js Display bullet next to request with errors in DarkConsole. 2013-04-25 18:30:13 -07:00
behavior-device.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-drag-and-drop-textarea.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-drag-and-drop.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-error-log.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-fancy-datepicker.js Allow datetime inputs to be optional 2013-05-30 16:19:43 -07:00
behavior-file-tree.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-form.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-gesture.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-global-drag-and-drop.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-history-install.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-hovercard.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-keyboard-pager.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-keyboard-shortcuts.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-konami.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-lightbox-attachments.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-more.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-object-selector.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-oncopy.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-phabricator-nav.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-phabricator-remarkup-assist.js Move Maniphest attached files section into textbox. 2013-05-26 13:46:51 -07:00
behavior-refresh-csrf.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-reveal-content.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-search-typeahead.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-toggle-class.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-tokenizer.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-tooltip.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-watch-anchor.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-workflow.js Generalize rules for "workflow" sigil 2013-06-05 16:21:21 -07:00
Busy.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
DragAndDropFileUpload.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
DraggableList.js Mostly generalize Maniphest's drag-and-drop list 2013-06-04 15:28:31 -07:00
DropdownMenu.js Randomsauce - make the align-rightness of PhabricatorDropdownMenu configurable 2013-05-22 16:08:23 -07:00
DropdownMenuItem.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
FileUpload.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
Hovercard.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
KeyboardShortcut.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
KeyboardShortcutManager.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
MultirowRowManager.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
Notification.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
phtize.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
Prefab.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
ShapedRequest.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
TextAreaUtils.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
ToolTip.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00