mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-18 19:40:55 +01:00
No description
94d0adb140
Summary: When a user hits 'cancel' on a 'new', 'edit', or 'reply' operation, add a little "Changes discarded. __Undo__" insert so they can get their change back. No undo for delete since there's an explicit prompt. Once this lands we can make 'escape' work again to close dialogs. This change started feeling really good when I was merging all the duplicate code and making things more consistent, but by the time I started writing client rendering it felt gross. I'm not really thrilled with it but I guess it's a step forward? The feature seems pretty OK in practice. Let me know how much barfing this causes and I can try to remedy the most acute concerns. This also fixes a bug where replies always (?) appear on the 'new' side of the diff (I think?). Test Plan: Applied 'new', 'edit', 'delete' and 'reply' operations, pressed 'cancel' and 'okay' in each case, with and without changing text where relevant. All behaviors seem to conform with expectations, except that canceling out of 'edit' without changing the text gives you an option to undo when it shouldn't really. There's no super easy way to get at the original text right now. Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: simpkins, aran, epriestley Differential Revision: 406 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support/aphlict | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| .gitmodules | ||
| CHANGELOG | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. You can learn more at http://phabricator.org/ as well as click around our development install. Developer mailing list at https://groups.google.com/group/phabricator-dev and please report issues using GitHub. WHAT IS PHABRICATOR? Phabricator is a suite of web applications that facilitate software development tasks, particularly code review. The primary application in the suite is Differential, a code review tool. Phabricator is highly unstable and has many missing features! These applications are being brought over from Facebook's internal toolset, but there's a lot of stuff that hasn't made it over yet. Feel free to follow the project but you probably shouldn't try to install this yet unless you're extremely ambitious or just want to take a look at it. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0