1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/view/control
Mike Riley 7aab7e80af Provide default values for table view properties which are counted
Summary:
PHP 7.2 has changed the behavior of `count`, you must provide an array or `Countable` as a parameter, otherwise a warning is generated.  These two class members are counted during rendering, and are commonly left as null properties.

https://wiki.php.net/rfc/counting_non_countables

Test Plan: Browsed around my install and stopped seeing `count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153]` everywhere.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D19140
2018-02-25 21:54:06 +00:00
..
AphrontCursorPagerView.php Redesign Application Search 2016-08-01 12:23:36 -07:00
AphrontTableView.php Provide default values for table view properties which are counted 2018-02-25 21:54:06 +00:00
AphrontTokenizerTemplateView.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
AphrontTypeaheadTemplateView.php Add javelin_tag(), convert easy callsites 2013-01-25 12:57:17 -08:00
PhabricatorObjectSelectorDialog.php When using the "Close as Duplicate" relationship action, limit the UI to 1 task 2016-06-30 13:48:21 -07:00