1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 08:06:13 +01:00
phorge-phorge/src/applications/maniphest/storage
epriestley 968ac76453 Don't adjust task priority after a workboard drag unless we need to
Summary:
Fixes T8197. Currently, if you priority-sort a workboard and drag a card to the top or bottom, we change the priority even if we do not need to.

For example, if the lowest priority in a column is "Low", and you drag a "Wishlist" task underneath it, we incorrectly increase the priority of the task to "Low", when we do not actually need to touch it. This is bad/confusing.

A similar thing happens when dragging a "High" priority task to the top of a column where the highest priority is currently "Normal".

Test Plan:
  - Create a column with a "Normal" task.
  - Sort workboard by Priority.
  - Drag a "High" task above it. After patch: task still "High".
  - Drag a "Wishlist" task below it. After patch: task still "Wishlist".

Also dragged a ton of tasks into the middle of other tasks.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8197

Differential Revision: https://secure.phabricator.com/D15240
2016-02-10 16:03:31 -08:00
..
ManiphestCustomFieldNumericIndex.php Various linter fixes. 2014-02-26 12:44:58 -08:00
ManiphestCustomFieldStorage.php Various linter fixes. 2014-02-26 12:44:58 -08:00
ManiphestCustomFieldStringIndex.php Various linter fixes. 2014-02-26 12:44:58 -08:00
ManiphestDAO.php Remove @group annotations 2014-07-10 08:12:48 +10:00
ManiphestNameIndex.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
ManiphestSchemaSpec.php Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
ManiphestTask.php Don't adjust task priority after a workboard drag unless we need to 2016-02-10 16:03:31 -08:00
ManiphestTransaction.php Fix a bad parameter in a parent::shouldHideForMail() call in Maniphest 2016-02-09 04:17:35 -08:00
ManiphestTransactionComment.php Rename "transactionpro" table to "transaction" 2013-09-24 10:49:16 -07:00