mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-22 18:28:47 +02:00
8c1c6fec5a
Summary: Ref T603. Fixes T2823. This updates Paste and Macro. - **Paste** - Added default view policy. - I didn't add a "create" policy, since I can't come up with any realistic scenario where you'd give users access to pastes but not let them create them. - **Macro** - Added a "manage" policy, which covers creating and editing macros. This lets an install only allow "People With An Approved Sense of Humor" or whatever to create macros. - Removed the "edit" policy, since giving individual users access to specific macros doesn't make much sense to me. - Changed the view policy to the "most public" policy the install allows. - Added view policy information to the header. Also fix a couple of minor things in Maniphest. Test Plan: - Set Paste policy, created pastes via web and Conduit, saw they got the right default policies. - Set Macro policy, tried to create/edit macros with valid and unauthorized users. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2823, T603 Differential Revision: https://secure.phabricator.com/D7317
45 lines
1.1 KiB
PHP
45 lines
1.1 KiB
PHP
<?php
|
|
|
|
abstract class PhabricatorMacroController
|
|
extends PhabricatorController {
|
|
|
|
protected function buildSideNavView($for_app = false) {
|
|
$nav = new AphrontSideNavFilterView();
|
|
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
|
|
|
|
if ($for_app) {
|
|
$nav->addLabel(pht('Create'));
|
|
$nav->addFilter('',
|
|
pht('Create Macro'),
|
|
$this->getApplicationURI('/create/'));
|
|
}
|
|
|
|
id(new PhabricatorMacroSearchEngine())
|
|
->setViewer($this->getRequest()->getUser())
|
|
->addNavigationItems($nav->getMenu());
|
|
|
|
return $nav;
|
|
}
|
|
|
|
public function buildApplicationMenu() {
|
|
return $this->buildSideNavView($for_app = true)->getMenu();
|
|
}
|
|
|
|
protected function buildApplicationCrumbs() {
|
|
$crumbs = parent::buildApplicationCrumbs();
|
|
|
|
$can_manage = $this->hasApplicationCapability(
|
|
PhabricatorMacroCapabilityManage::CAPABILITY);
|
|
|
|
$crumbs->addAction(
|
|
id(new PHUIListItemView())
|
|
->setName(pht('Create Macro'))
|
|
->setHref($this->getApplicationURI('/create/'))
|
|
->setIcon('create')
|
|
->setDisabled(!$can_manage)
|
|
->setWorkflow(!$can_manage));
|
|
|
|
return $crumbs;
|
|
}
|
|
|
|
}
|