1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-07 13:21:02 +01:00
phorge-phorge/src/applications/people
epriestley 08de131da5 Begin modularizing main menu items
Summary:
Ref T10077. Ref T8918. The way the main menu is built is not very modular and fairly hacky.

It assumes menus are provided by applications, but this isn't exactly true. Notably, the "Quick Create" menu is not per-application.

The current method of building this menu is very inefficient (see T10077). Particularly, we have to build it //twice// because we need to build it once to render the item and then again to render the dropdown options.

Start cleaning this up. This diff doesn't actually have any behavioral changes, since I can't swap the menu over until we get rid of all the other items and I haven't extended this to Notifications/Conpherence yet so it doesn't actually fix T8918.

Test Plan: Viewed menus while logged in, logged out, in different applications, in desktop/mobile. Nothing appeared different.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8918, T10077

Differential Revision: https://secure.phabricator.com/D14922
2016-01-04 06:57:09 -08:00
..
application Begin modularizing main menu items 2016-01-04 06:57:09 -08:00
capability People - refine permissions on creating new users 2015-02-05 16:47:09 -08:00
conduit Add "Mailing List" users 2015-06-03 18:42:33 -07:00
config Add getGroup to ConfigOptions 2015-02-09 13:10:56 -08:00
controller Remove all setObjectURI() from ActionListViews 2015-12-17 08:30:22 -08:00
customfield Add "Mailing List" users 2015-06-03 18:42:33 -07:00
editor Add "Mailing List" users 2015-06-03 18:42:33 -07:00
engineextension Modernize Hovercard implementation 2015-12-24 12:18:28 -08:00
extension Begin modularizing main menu items 2016-01-04 06:57:09 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
lipsum Improve bin/lipsum UX 2015-12-24 09:06:35 -08:00
markup Replace user "status" with "availability" 2015-05-14 11:15:04 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
policyrule Move some files around 2015-11-17 06:26:13 +11:00
query Badges ... on your profile 2015-07-23 11:46:34 -07:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
searchfield Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
storage Separate external editor integration from callsigns 2016-01-04 06:54:01 -08:00
typeahead Mark some strings for translation 2015-06-09 23:06:52 +10:00
view Let users review their own account activity logs 2014-04-27 17:32:09 -07:00