mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 17:52:43 +01:00
3a87a95e11
Summary: Ref T603. Make almost every task read policy-aware. Notable exceptions are: - Edge editor -- this stuff is prescreened and should be moved to ApplicationTransactions eventually anyway. - Search/attach stuff -- this stuff needs some general work. The actual list should be fine since you can't pull handles. There may be a very indirect hole here where you could attach an object you can't see (but do know the ID of) to an object you can see. Pretty fluff. - The "Tasks" field in Differential will let you reference objects you can't see. Possibly this is desirable, in the case of commandeering revisions. Mostly, it was inconvenient to get a viewer (I think). Test Plan: - Called `maniphest.info`. - Called `maniphest.update`. - Batch edited tasks. - Dragged and dropped tasks to change subpriority. - Subscribed and unsubscribed from a task. - Edited a task. - Created a task. - Created a task with a parent. - Created a task with a template. - Previewed a task update. - Commented on a task. - Added a dependency. - Searched for "T33" in object search dialog. - Created a branch "T33", ran `arc diff`, verified link. - Pushed a commit with "Fixes T33", verified close. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7119
131 lines
3.5 KiB
PHP
131 lines
3.5 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group maniphest
|
|
*/
|
|
final class ManiphestTransactionPreviewController extends ManiphestController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = $data['id'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$comments = $request->getStr('comments');
|
|
|
|
$task = id(new ManiphestTaskQuery())
|
|
->setViewer($user)
|
|
->withIDs(array($this->id))
|
|
->executeOne();
|
|
if (!$task) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
id(new PhabricatorDraft())
|
|
->setAuthorPHID($user->getPHID())
|
|
->setDraftKey($task->getPHID())
|
|
->setDraft($comments)
|
|
->replaceOrDelete();
|
|
|
|
$action = $request->getStr('action');
|
|
|
|
$transaction = new ManiphestTransaction();
|
|
$transaction->setAuthorPHID($user->getPHID());
|
|
$transaction->setTransactionType($action);
|
|
|
|
// This should really be split into a separate transaction, but it should
|
|
// all come out in the wash once we fully move to modern stuff.
|
|
$transaction->attachComment(
|
|
id(new ManiphestTransactionComment())
|
|
->setContent($comments));
|
|
|
|
$value = $request->getStr('value');
|
|
// grab phids for handles and set transaction values based on action and
|
|
// value (empty or control-specific format) coming in from the wire
|
|
switch ($action) {
|
|
case ManiphestTransaction::TYPE_PRIORITY:
|
|
$transaction->setOldValue($task->getPriority());
|
|
$transaction->setNewValue($value);
|
|
break;
|
|
case ManiphestTransaction::TYPE_OWNER:
|
|
if ($value) {
|
|
$value = current(json_decode($value));
|
|
$phids = array($value);
|
|
} else {
|
|
$phids = array();
|
|
}
|
|
$transaction->setNewValue($value);
|
|
break;
|
|
case ManiphestTransaction::TYPE_CCS:
|
|
if ($value) {
|
|
$value = json_decode($value);
|
|
}
|
|
if (!$value) {
|
|
$value = array();
|
|
}
|
|
$phids = $value;
|
|
|
|
foreach ($task->getCCPHIDs() as $cc_phid) {
|
|
$phids[] = $cc_phid;
|
|
$value[] = $cc_phid;
|
|
}
|
|
|
|
$transaction->setOldValue($task->getCCPHIDs());
|
|
$transaction->setNewValue($value);
|
|
break;
|
|
case ManiphestTransaction::TYPE_PROJECTS:
|
|
if ($value) {
|
|
$value = json_decode($value);
|
|
}
|
|
if (!$value) {
|
|
$value = array();
|
|
}
|
|
|
|
$phids = $value;
|
|
foreach ($task->getProjectPHIDs() as $project_phid) {
|
|
$phids[] = $project_phid;
|
|
$value[] = $project_phid;
|
|
}
|
|
|
|
$transaction->setOldValue($task->getProjectPHIDs());
|
|
$transaction->setNewValue($value);
|
|
break;
|
|
default:
|
|
$phids = array();
|
|
$transaction->setNewValue($value);
|
|
break;
|
|
}
|
|
$phids[] = $user->getPHID();
|
|
|
|
$handles = $this->loadViewerHandles($phids);
|
|
|
|
$transactions = array();
|
|
$transactions[] = $transaction;
|
|
|
|
$engine = new PhabricatorMarkupEngine();
|
|
$engine->setViewer($user);
|
|
if ($transaction->hasComment()) {
|
|
$engine->addObject(
|
|
$transaction->getComment(),
|
|
PhabricatorApplicationTransactionComment::MARKUP_FIELD_COMMENT);
|
|
}
|
|
$engine->process();
|
|
|
|
$transaction->setHandles($handles);
|
|
|
|
$view = id(new PhabricatorApplicationTransactionView())
|
|
->setUser($user)
|
|
->setTransactions($transactions)
|
|
->setIsPreview(true)
|
|
->setIsDetailView(true);
|
|
|
|
return id(new AphrontAjaxResponse())
|
|
->setContent((string)phutil_implode_html('', $view->buildEvents()));
|
|
}
|
|
|
|
}
|