mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 22:10:55 +01:00
dba4c4bdf6
Summary: See PHI399. Ref T4340. This header provides an additional layer of protection against various attacks, including XSS attacks which embed inline `<script ...>` or `onhover="..."` content into the document. **style-src**: The "unsafe-inline" directive affects both `style="..."` and `<style>`. We use a lot of `style="..."`, some very legitimately, so we can't realistically get away from this any time soon. We only use one `<style>` (for monospaced font preferences) but can't disable `<style>` without disabling `style="..."`. **img-src**: We use "data:" URIs to inline small images into CSS, and there's a significant performance benefit from doing this. There doesn't seem to be a way to allow "data" URIs in CSS without allowing them in the document itself. **script-src** and **frame-src**: For a small number of flows (Recaptcha, Stripe) we embed external javascript, some of which embeds child elements (or additional resources) into the document. We now whitelist these narrowly on the respective pages. This won't work with Quicksand, so I've blacklisted it for now. **connect-src**: We need to include `'self'` for AJAX to work, and any websocket URIs. **Clickjacking**: We now have three layers of protection: - X-Frame-Options: works in older browsers. - `frame-ancestors 'none'`: does the same thing. - Explicit framebust in JX.Stratcom after initialization: works in ancient IE. We could probably drop the explicit framebust but it wasn't difficult to retain. **script tags**: We previously used an inline `<script>` tag to start Javelin. I've moved this to `<data data-javelin-init ...>` tags, which seems to work properly. **`__DEV__`**: We previously used an inline `<script>` tag to set the `__DEV__` mode flag. I tried using the "initialization" tags for this, but they fire too late. I moved it to `<html data-developer-mode="1">`, which seems OK everywhere. **CSP Scope**: Only the CSP header on the original request appears to matter -- you can't refine the scope by emitting headers on CSS/JS. To reduce confusion, I disabled the headers on those response types. More headers could be disabled, although we're likely already deep in the land of diminishing returns. **Initialization**: The initialization sequence has changed slightly. Previously, we waited for the <script> in bottom of the document to evaluate. Now, we go fishing for tags when domcontentready fires. Test Plan: - Browsed around in Firefox, Safari and Chrome looking for console warnings. Interacted with various Javascript behaviors. Enabled Quicksand. - Disabled all the framebusting, launched a clickjacking attack, verified that each layer of protection is individually effective. - Verified that the XHProf iframe in Darkconsole and the PHPAST frame layout work properly. - Enabled notifications, verified no complaints about connecting to Aphlict. - Hit `__DEV__` mode warnings based on the new data attribute. - Tried to do sketchy stuff with `data:` URIs and SVGs. This works but doesn't seem to be able to do anything dangerous. - Went through the Stripe and Recaptcha workflows. - Dumped and examined the CSP headers with `curl`, etc. - Added a raw <script> tag to a page (as though I'd found an XSS attack), verified it was no longer executed. Maniphest Tasks: T4340 Differential Revision: https://secure.phabricator.com/D19143 |
||
|---|---|---|
| .. | ||
| builtin | ||
| celerity | ||
| cows | ||
| emoji | ||
| figlet/custom | ||
| font | ||
| sprite | ||
| sql | ||
| sshd | ||