1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/search
epriestley 1a001ca033 Render ApplicationSearch errors correctly
Summary:
Fixes T8774. When an ApplicationSearch page returned an error (e.g., using a "viewer()" query while logged out), we would try to add action links to a box without a header. Instead:

  - If a box has no header, but has show/hide actions, just create an empty header so the view renders. This is a little silly looking but does what the caller asks.
  - Always set the title on the result box, so we get a header.

Test Plan: Did an invalid (logged out, with viewer()) search. Did a valid search.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8774

Differential Revision: https://secure.phabricator.com/D13576
2015-07-07 11:52:06 -07:00
..
application Maniphest - prevent uneditable tasks from being able to be closed as duplicates 2015-05-18 13:07:05 -07:00
applicationpanel Modernize search engine selection 2015-05-20 06:59:59 +10:00
config Modernize search engine selection 2015-05-20 06:59:59 +10:00
constants Extend from Phobject 2015-06-15 18:02:27 +10:00
controller Render ApplicationSearch errors correctly 2015-07-07 11:52:06 -07:00
engine Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
field Move some PhabricatorSearchField subclasses 2015-07-06 22:52:05 +10:00
index Extend from Phobject 2015-06-15 18:02:27 +10:00
interface Provide PhabricatorSavedQuery to renderResultsList() 2013-07-03 05:46:04 -07:00
management phtize all the things 2015-05-22 21:16:39 +10:00
query [Redesign] PhabricatorApplicationSearchResultView 2015-06-19 11:46:20 +01:00
storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
typeahead Use typeaheads instead of checkbox lists for task status / priority 2015-04-23 11:49:34 -07:00
view [Redesign] Remove AphrontTable restriction on Search Engine 2015-06-29 12:28:55 -07:00
worker Fix visibility of the PhabricatorWorker::doWork() methods 2015-01-16 06:58:50 +11:00