1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/externals
epriestley ee814923a2 Improve Amazon SES code error handling behavior
Summary:
Fixes T10728. Fixes T10476. SES uses third-party code with unique, creative ideas about error handling.

  - Make the error handling behavior more correct, so it doesn't try to use undefined variables.
  - Simplify the error handling behavior (throw exceptions sooner, remove redundant code).
  - Explicitly test for `-smtp` misconfigurations. These can arise if you read the wrong column out of the table in the AWS docs, as in T10728.
  - Explicitly test for SimpleXML, to catch T10476 before it does damage.

Test Plan:
  - Configured SES to use a bogus SMTP endpoint.
  - Faked past the SMTP check, hit sane error on the connection.
  - Undid faking, hit immediate hard stop on the STMP check.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10476, T10728

Differential Revision: https://secure.phabricator.com/D15632
2016-04-05 17:28:45 -07:00
..
amazon-ses Improve Amazon SES code error handling behavior 2016-04-05 17:28:45 -07:00
cowsay Use PHP implementation of Cowsay for cowsay rule 2015-09-13 12:27:30 -07:00
diff_match_patch Phragment v0 2013-12-07 12:43:49 +11:00
figlet Include "Figlet" and PEAR "Text_Figlet" in externals 2015-09-13 12:30:48 -07:00
httpful Add Balanced Payments API 2013-04-25 09:47:30 -07:00
JsShrink Update JsShrink external library. 2014-06-07 11:26:20 -07:00
mimemailparser Work around mailparse bug (?) with messages that have no terminal newline 2015-04-21 09:49:40 -07:00
pear-figlet Use PEAR Text_Figlet to render figlet fonts 2015-09-13 12:31:07 -07:00
phpmailer Changed default timeout of smtp from 10s to 60s. 2014-04-24 04:59:22 -07:00
phpqrcode Quickly fix phpqrcode syntax 2015-08-31 14:05:51 -07:00
recaptcha PhabricatorEnv 2011-01-31 11:55:26 -08:00
restful Add Balanced Payments API 2013-04-25 09:47:30 -07:00
stripe-php Update Stripe PHP API 2014-07-13 09:19:07 -07:00
twilio-php Remove some needless +x flags. 2014-05-17 15:41:12 -07:00
wepay Strip +x from some WePay files 2013-11-12 17:48:47 -08:00
wordlist Add a common password blacklist 2014-01-23 14:01:18 -08:00
xhprof Fix some issues caught by HipHop, and work around some issues 2011-02-26 21:01:42 -08:00