1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
phorge-phorge/src/applications/owners
epriestley c125ab7a42 Remove "metamta.*.subject-prefix" options
Summary:
In ~2012, the first of these options was added because someone who hates dogs and works at Asana also hated `[Differential]` in the subject line. The use case there was actually //removing// the text, not changing it, but I made the prefix editable since it seemed like slightly less of a one-off.

These options are among the dumbest and most useless config options we have and very rarely used, see T11760. A very small number of instances have configured one of these options.

Newer applications stopped providing these options and no one has complained.

You can get the same effect with `translation.override`. Although I'm not sure we'll keep that around forever, it's a reasonable replacement today. I'll call out an example in the changelog to help installs that want to preserve this option.

If we did want to provide this, it should just be in {nav Applications > Settings} for each application, but I think it's wildly-low-value and "hack via translations" or "local patch" are entirely reasonable if you really want to change these strings.

Test Plan: Grepped for `subject-prefix`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19993
2019-01-17 19:18:50 -08:00
..
application Give Owners packages the "O" monogram 2016-05-13 17:18:15 -07:00
capability Give Owners real view and edit policies 2016-02-15 11:56:35 -08:00
conduit Formally deprecate owners.query Conduit API method 2016-04-20 09:04:45 -07:00
config Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
controller Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_" 2018-09-12 12:44:43 -07:00
customfield Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
engineextension Treat Owners paths like "/src/backend" and "/src/backend/" identically 2018-03-06 20:31:46 -08:00
lipsum Add an owners package generator for Lipsum 2017-02-27 09:11:04 -08:00
mail Build separate mail for each recipient, honoring recipient access levels 2015-06-03 18:59:31 -07:00
phid Add more mail stamps: tasks, subscribers, projects, spaces 2018-02-06 04:05:46 -08:00
query When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision" 2018-11-15 20:50:21 -08:00
remarkup Give Owners packages the "O" monogram 2016-05-13 17:18:15 -07:00
search Support Ferret engine in Owners 2017-09-07 13:23:46 -07:00
searchfield Flesh out Conduit parmeter types for maniphest.search 2015-12-14 04:24:01 -08:00
storage Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
typeahead Fix packages(project) to work properly and add it to "MailableFunctionDatasource" 2018-10-19 13:53:27 -07:00
xaction Allow Owners packages to be configured to ignore generated paths in Differential 2018-05-05 08:47:29 -07:00