1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/webroot/rsrc/css/application/differential
epriestley 98fe8fae4a Use <td class="n" data-n="3"> instead of <th>3</th> for line numbers
Summary:
Ref T13161. Ref T12822. See PHI870. Long ago, the web was simple. You could leave your doors unlocked, you knew all your neighbors, crime hadn't been invented yet, and `<th>3</th>` was a perfectly fine way to render a line number cell containing the number "3".

But times have changed!

  - In PHI870, this isn't good for screenreaders. We can't do much about this, so switch to `<td>`.
  - In D19349 / T13105 and elsewhere, this `::after { content: attr(data-n); }` approach seems like the least bad general-purpose approach for preventing line numbers from being copied. Although Differential needs even more magic beyond this in the two-up view, this is likely good enough for the one-up view, and is consistent with other views (paste, harbormaster logs, general source display) where this technique is sufficient on its own.

The chance this breaks //something// is pretty much 100%, but we've got a week to figure out what it breaks. I couldn't find any issues immediately.

Test Plan:
  - Created, edited, deleted inlines in 1-up and 2-up views.
  - Replied, keyboard-navigated, keyboard-replied, drag-selected, poked and prodded everything.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13161, T12822

Differential Revision: https://secure.phabricator.com/D20188
2019-02-19 15:07:02 -08:00
..
add-comment.css Revamp inline commenting UI 2015-03-27 16:00:09 -07:00
changeset-view.css Use <td class="n" data-n="3"> instead of <th>3</th> for line numbers 2019-02-19 15:07:02 -08:00
core.css Convert Differential to new layout 2016-03-12 13:04:21 -08:00
phui-inline-comment.css Lots of little fixes for Dark Mode (Experimental) 2017-07-19 14:41:23 -07:00
revision-comment.css Highlight cell when jumping to an inline comment 2015-05-04 12:21:21 -07:00
revision-history.css Modernize "revision update history" in Differential 2014-03-12 11:39:43 -07:00
revision-list.css Update table 'age' colors to table-kit mocks. 2013-01-15 13:16:24 -08:00
table-of-contents.css Improve lint/unit limit, sort, view all, collapse behaviors 2015-06-23 13:34:25 -07:00