1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-27 16:00:59 +01:00
phorge-phorge/webroot/rsrc/css/application
epriestley 70d67a3908 Fix the most significant "phantom notification" badness
Summary:
Ref T13124. Ref T13131. Fixes T8953. See PHI512.

When you receieve a notification about an object and then someone hides that object from you (or deletes it), you get a phantom notification which is very difficult to clear.

For now, test that notifications are visible when you open the menu and clear any that are not.

This could be a little more elegant than it is, but the current behavior is very clearly broken. This unbreaks it, at least.

Test Plan:
  - As Alice, configured task stuff to notify me (instead of sending email).
  - As Bailey, added Alice as a subscriber to a task, then commented on it.
  - As Alice, loaded home and saw a notification count. Didn't click it yet.
  - As Bailey, set the task to private.
  - As Alice, clicked the notification bell menu icon.
    - Before change: no unread notifications, bell menu is semi-stuck in a phantom state which you can't clear.
    - After change: bad notifications automatically cleared.

{F5530005}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13131, T13124, T8953

Differential Revision: https://secure.phabricator.com/D19384
2018-04-19 17:24:19 -07:00
..
almanac Allow Almanac service types to define default properties 2014-12-17 11:10:50 -08:00
auth Touch up auth external account ui 2015-07-18 08:51:25 -07:00
base Fix the most significant "phantom notification" badness 2018-04-19 17:24:19 -07:00
chatlog [Redesign] Larger Font PostProcessor 2015-06-26 09:33:03 -07:00
conduit Show how to call Conduit API methods from clients 2015-05-08 12:19:52 -07:00
config Issue setup guidance recommending MySQLi and MySQL Native Driver 2018-03-13 12:38:09 -07:00
conpherence Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
contentsource Move #888 and #999 to $lightgreytext 2013-09-02 08:12:18 -07:00
countdown Increase specificity in blue property boxes 2016-05-03 17:26:31 -07:00
daemon Execute Maniphest batch edits in the background with a web UI progress bar 2015-06-23 13:36:16 -07:00
dashboard Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
diff Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
differential Mostly make blame work with DocumentEngine 2018-04-09 04:48:21 -07:00
diffusion Mostly make blame work with DocumentEngine 2018-04-09 04:48:21 -07:00
feed [Redesign] Update Feed 2015-05-28 11:47:06 -07:00
files Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
flag Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
harbormaster Improve live Harbormaster log follow behaviors 2018-03-01 13:11:22 -08:00
herald Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
maniphest Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions 2018-01-19 12:43:47 -08:00
objectselector Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
owners Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners 2018-03-07 20:57:24 -08:00
paste Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
people Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
phame Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
pholio Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
phortune Add a basic invoice view for printing to Phortune 2016-10-29 17:46:47 -07:00
phrequent UIColor Blues and common color integration 2013-09-02 08:10:47 -07:00
phriction Fix Phriction document linking in mail bodies 2016-04-20 06:55:00 -07:00
policy Clean up Multirow Manager UI 2014-11-17 14:06:05 -08:00
ponder Minor Ponder spacing updates 2016-03-03 15:22:33 -08:00
project Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
releeph Use standard UI elements to render pull requests in Releeph 2014-04-18 06:44:45 -07:00
search Mobile layouts for Diffusion 2017-08-30 12:28:00 -07:00
slowvote Solidify PHUITwoColumnView as a page layout 2016-03-01 07:23:08 -08:00
tokens Make tokens more accessible to assitive technologies 2014-05-05 10:54:34 -07:00
uiexample Clean up FontAwesome / Timeline CSS 2014-04-22 18:29:14 -07:00