1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
phorge-phorge/webroot/rsrc
epriestley 9a8eb4026e Make race condition window for Conpherence smaller and rarer
Summary:
Ref T6713. This isn't very clean, and primarily unblocks D11143.

After D11143, I have a reliable local race where I submit, get a notification immediately, then get a double update (form submission + notification-triggered update).

Instead, make the notification updates wait for form submissions.

This doesn't resolve the race completely. The notification updates don't block chat submission (only the other way around), so if you're really fast you can submit at the same time someone else sends chat and race. But this fixes the most glaring issue.

The overall structure here is still pretty shaky but I tried to improve things a little, at least.

Test Plan: Chatted with myself, saw 0 races instead of 100% races.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T6713

Differential Revision: https://secure.phabricator.com/D11277
2015-01-08 09:44:02 -08:00
..
css Change CLOSED colors to Indigo over Black 2015-01-05 11:19:01 -08:00
externals Add JX.Leader: synchronization over localStorage 2015-01-06 17:50:40 -08:00
favicons Add HiDPI favicons 2014-11-07 17:07:38 -08:00
image Add font-awesome-ish project icons 2015-01-04 09:09:13 -08:00
js Make race condition window for Conpherence smaller and rarer 2015-01-08 09:44:02 -08:00
swf React to Aphlict disconnects in the UI 2014-06-24 09:41:40 -07:00