mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
9b3d7b0dba
Summary: Ref T603. Makes the majority of reads policy aware (and pretty much all the important ones). Test Plan: - Created a comment with `differential.createcomment`. - Created a new revision with `arc diff` in order to exercise `differential.creatediff`. - Created an inline comment with `differential.createinline`. - Added a comment to a revision. - Edited an inline comment. - Edited a revision. - Wrote "Depends on ..." in a summary, saved, verified link was created. - Browsed a file in Diffusion. - Got past the code I changed in the Releeph request thing. - Edited a Releeph request. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7136
89 lines
2.7 KiB
PHP
89 lines
2.7 KiB
PHP
<?php
|
|
|
|
final class DifferentialCommentSaveController extends DifferentialController {
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
if (!$request->isFormPost()) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$viewer = $request->getUser();
|
|
|
|
$revision_id = $request->getInt('revision_id');
|
|
$revision = id(new DifferentialRevisionQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($revision_id))
|
|
->executeOne();
|
|
if (!$revision) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$comment = $request->getStr('comment');
|
|
$action = $request->getStr('action');
|
|
$reviewers = $request->getArr('reviewers');
|
|
$ccs = $request->getArr('ccs');
|
|
|
|
$editor = new DifferentialCommentEditor(
|
|
$revision,
|
|
$action);
|
|
|
|
$content_source = PhabricatorContentSource::newForSource(
|
|
PhabricatorContentSource::SOURCE_WEB,
|
|
array(
|
|
'ip' => $request->getRemoteAddr(),
|
|
));
|
|
|
|
try {
|
|
$editor
|
|
->setActor($request->getUser())
|
|
->setMessage($comment)
|
|
->setContentSource($content_source)
|
|
->setAttachInlineComments(true)
|
|
->setAddedReviewers($reviewers)
|
|
->setAddedCCs($ccs)
|
|
->save();
|
|
} catch (DifferentialActionHasNoEffectException $no_effect) {
|
|
$has_inlines = id(new DifferentialInlineCommentQuery())
|
|
->withDraftComments($request->getUser()->getPHID(), $revision->getID())
|
|
->execute();
|
|
|
|
$dialog = new AphrontDialogView();
|
|
$dialog->setUser($request->getUser());
|
|
$dialog->addCancelButton('/D'.$revision_id);
|
|
|
|
$dialog->addHiddenInput('revision_id', $revision_id);
|
|
$dialog->addHiddenInput('action', 'none');
|
|
$dialog->addHiddenInput('reviewers', $reviewers);
|
|
$dialog->addHiddenInput('ccs', $ccs);
|
|
$dialog->addHiddenInput('comment', $comment);
|
|
|
|
$dialog->setTitle(pht('Action Has No Effect'));
|
|
$dialog->appendChild(
|
|
phutil_tag('p', array(), $no_effect->getMessage()));
|
|
|
|
if (strlen($comment) || $has_inlines) {
|
|
$dialog->addSubmitButton(pht('Post as Comment'));
|
|
$dialog->appendChild(phutil_tag('br'));
|
|
$dialog->appendChild(phutil_tag('p', array(), pht(
|
|
'Do you want to post your feedback anyway, as a normal comment?')));
|
|
}
|
|
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
|
|
// TODO: Diff change detection?
|
|
|
|
$draft = id(new PhabricatorDraft())->loadOneWhere(
|
|
'authorPHID = %s AND draftKey = %s',
|
|
$request->getUser()->getPHID(),
|
|
'differential-comment-'.$revision->getID());
|
|
if ($draft) {
|
|
$draft->delete();
|
|
}
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI('/D'.$revision->getID());
|
|
}
|
|
|
|
}
|