1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/herald
epriestley b2890eeb0e Add "final" to all Phabricator "Controller" classes
Summary:
These are all unambiguously unextensible. Issues I hit:

  - Maniphest Change/Diff controllers, just consolidated them.
  - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects.
  - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962.

Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1843
2012-03-09 15:46:25 -08:00
..
adapter Migrate "PhabricatorOwnersPackageCommitRelationship" to "PhabricatorRepositoryAuditRequest" 2012-03-05 13:17:29 -08:00
config Allow Herald to trigger audits for users or projects 2012-02-27 09:36:30 -08:00
controller Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
engine Disable personal Herald rules from invalid owners 2012-01-31 12:11:31 -08:00
storage Allow Herald to trigger audits for users or projects 2012-02-27 09:36:30 -08:00
view Improve Herald personal/global UI/UX 2012-01-31 12:09:29 -08:00