1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-13 12:54:53 +01:00
phorge-phorge/src/applications/diffusion
Andre Klapper 9cd62bdcc4 Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/srv/phorge/phorge/src/applications/diffusion/query/DiffusionCommitQuery.php:779]
```

Closes T15936

Test Plan: Unclear.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15936

Differential Revision: https://we.phorge.it/D25821
2024-09-20 08:49:08 +02:00
..
application Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
config Update URI in bugtraq.logregex description 2024-05-01 11:42:26 +02:00
controller Subversion: fix empty "Authored on" date on commit pages 2024-08-24 15:34:48 +02:00
data Drop question mark suffix from optional PHPDoc @param types 2024-09-06 19:17:00 +02:00
document Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1 2023-07-05 08:44:24 +01:00
doorkeeper Modernize and clean up "PhabricatorAuditStatusConstants" 2021-03-10 09:21:55 -08:00
edge Diffusion commits: add some edge phrases about Revisions 2023-07-06 13:32:21 +02:00
editfield Assign RepositoryIdentity objects to commits 2018-05-31 07:28:23 -07:00
editor Allow to uninstall (hide) Audit application 2024-02-12 12:10:06 +01:00
engine Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
engineextension Correct minor "jump to symbol" behavior in Differential 2021-03-17 15:32:07 -07:00
exception Filter and reject "--config" and "--debugger" flags to Mercurial in any position 2017-11-10 08:42:07 -08:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
gitlfs Fix a missing getSSHUser() callsite 2018-01-31 15:34:12 -08:00
harbormaster Pass commit authorship information to Buildkite 2018-08-27 12:52:11 -07:00
herald Allow to uninstall (hide) Audit application 2024-02-12 12:10:06 +01:00
identity Add a "--dry-run" flag to "bin/repository rebuild-identities" 2019-11-19 12:38:20 -08:00
management Fix PHP 8.1 "strlen(null)" and "preg_match()" exceptions which block repository creation 2023-05-19 17:18:37 +02:00
panel Remove product literal strings in "pht()", part 18 2022-04-25 16:46:25 -07:00
protocol Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
query Fix PHP 8.1 "strlen(null)" exception in SVN commit query without identifier 2024-09-20 08:49:08 +02:00
ref Allow repository service lookups to return an ordered list of service refs 2019-09-03 10:05:40 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion 2019-05-21 13:12:28 -07:00
request PHPDoc: Replace "@return this" with "@return $this" 2024-09-09 15:48:09 +02:00
response Implement a Git LFS server which supports no operations 2016-03-17 08:08:43 -07:00
searchfield Assign RepositoryIdentity objects to commits 2018-05-31 07:28:23 -07:00
ssh Remove product literal strings in "pht()", part 18 2022-04-25 16:46:25 -07:00
symbol Provide character position information to symbol queries 2018-01-26 13:01:57 -08:00
typeahead Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
view Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
worker When updating revisions in responset to commits, use the omnipotent viewer to pull diffs 2021-03-01 11:11:34 -08:00
xaction Allow to uninstall (hide) Audit application 2024-02-12 12:10:06 +01:00
DiffusionCommitAuditStatus.php Enrich "diffusion.commit.search" with identity, status, and message information 2018-09-12 12:45:44 -07:00
DiffusionLintSaveRunner.php Continue cleaning up queries in the wake of changes to "%Q" 2018-11-16 12:49:44 -08:00