Andre Klapper 43539b220c Remove trivial cases of unreachable code ... Summary: Static code analysis can detect `Unreachable statement - code above always terminates.` The vast majority of occurrences in the Phorge codebase are due to an unreachable `break` within a `case` after a `return` or after an all-covering `if/else`. All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases. Test Plan: Examine the code; run static code analysis. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25802		2024-09-04 12:17:28 +02:00
..
application	Show more in Application Detail and List view	2023-11-21 11:22:23 -07:00
bulk	Remove the Maniphest-specific bulk job type	2018-01-19 12:44:16 -08:00
capability	Remove deprecated Maniphest "Can Edit <Specific Property>" capabilities	2018-08-16 10:51:06 -07:00
command	Use keywords instead of ints to update task priority in ManiphestEditEngine	2017-06-14 14:43:03 -07:00
conduit	Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent	2017-11-22 11:13:53 -08:00
config	Remove product literal strings in "pht()", part 6	2022-04-25 12:22:28 -07:00
constants	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
controller	Add Open Graph protocol meta tags to Maniphest task pages	2024-08-07 13:54:11 +02:00
edge	Allow duplicates and merged-in tasks to be queried with edge.search	2017-10-13 13:12:50 -07:00
editor	Warn in comment field if task is closed as duplicate	2024-06-23 15:29:17 +02:00
engine	Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked	2019-03-07 12:27:11 -08:00
engineextension	Fix task hovercards showing a "Not Editable" state	2019-03-26 15:56:09 -07:00
field	Remove unused method shouldCopyWhenCreatingSimilarTask()	2024-06-03 15:39:23 +02:00
herald	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
httpparametertype	Make "Create Subtask" work properly in EditEngine	2015-12-08 14:29:58 -08:00
lipsum	Remove all readers/writers for task "subpriority"	2019-03-12 12:57:04 -07:00
mail	Allow multiple mail receivers to react to an individual email	2019-01-16 12:28:02 -08:00
phid	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
policy	Update the "owner can always view/edit" policy exception rule	2019-11-18 21:54:45 -08:00
policyrule	Allow PolicyRules to serve as "Object Policies"	2015-06-13 15:44:38 -07:00
query	Improve error passing task IDs as URL parameter in invalid format	2024-05-29 12:11:10 +02:00
relationship	Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subject	2019-01-16 13:27:10 -08:00
remarkup	Rename PhutilRemarkupRule subclasses	2014-08-05 00:55:43 +10:00
search	Remove Ferret function aliases and overrides	2020-04-16 13:40:17 -07:00
storage	Remove trivial cases of unreachable code	2024-09-04 12:17:28 +02:00
typeahead	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
view	Add (Advanced) Custom Fields to Item List	2024-05-11 13:25:41 +03:00
xaction	Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction	2024-08-07 13:57:07 +02:00