1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-16 11:52:40 +01:00
phorge-phorge/src/applications/search/field
epriestley 8ec413b972 Clean up "ids" and "phids" handling in SearchEngines
Summary:
Ref T9964. I added several hacks to get these working. Clean them up and pull this into a proper extension.

The behavior in the web UI is:

  - they work in all applications; but
  - they only show up in the UI if a value is specified.

So if you visit `/view/?ids=1,2` you get the field, but normally it's not present. We could refine this later. I'm going to add documentation about how to prefill these forms regardless, which should make this discoverable by reading the documentation.

There's one teensey weensey hack: in the API, I push these fields to the top of the table. That one feels OK, since it's purely a convenience/display adjustment.

Test Plan: Queried by IDs, reviewed docs.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9964

Differential Revision: https://secure.phabricator.com/D14769
2015-12-14 04:24:54 -08:00
..
PhabricatorIDsSearchField.php Clean up "ids" and "phids" handling in SearchEngines 2015-12-14 04:24:54 -08:00
PhabricatorPHIDsSearchField.php Clean up "ids" and "phids" handling in SearchEngines 2015-12-14 04:24:54 -08:00
PhabricatorSearchCheckboxesField.php Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
PhabricatorSearchCustomFieldProxyField.php Flesh out Conduit parameter types for Owners + CustomFields 2015-12-14 04:23:44 -08:00
PhabricatorSearchDatasourceField.php Flesh out Conduit parmeter types for maniphest.search 2015-12-14 04:24:01 -08:00
PhabricatorSearchDateControlField.php Refactor Calendar Search, and implement Projects on events 2015-06-22 13:27:37 -07:00
PhabricatorSearchDateField.php Flesh out Conduit types for Paste search fields 2015-12-14 04:23:28 -08:00
PhabricatorSearchField.php Clean up "ids" and "phids" handling in SearchEngines 2015-12-14 04:24:54 -08:00
PhabricatorSearchOrderField.php Make "Order By" field render correctly when showing a SavedQuery with an order alias 2015-06-09 13:49:01 -07:00
PhabricatorSearchSelectField.php Convert Macro to SearchFields 2015-06-08 12:22:09 -07:00
PhabricatorSearchStringListField.php Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
PhabricatorSearchSubscribersField.php Flesh out Conduit types for Paste search fields 2015-12-14 04:23:28 -08:00
PhabricatorSearchTextField.php Move Projects to SearchFields 2015-06-08 12:20:16 -07:00
PhabricatorSearchThreeStateField.php Convert Files to SearchFields 2015-06-07 07:32:09 -07:00
PhabricatorSearchTokenizerField.php Make Subscribers automatically provide working SearchFields 2015-06-08 12:20:53 -07:00