1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
phorge-phorge/webroot/rsrc
epriestley 9d3a722eb1 When proxying an "{image ...}" image fails, show the user an error message
Summary:
Depends on D19192. Ref T4190. Ref T13101. Instead of directly including the proxy endpoint with `<img src="..." />`, emit a placeholder and use AJAX to make the request. If the proxy fetch fails, replace the placeholder with an error message.

This isn't the most polished implementation imaginable, but it's much less mysterious about errors.

Test Plan: Used `{image ...}` for valid and invalid images, got images and useful error messages respectively.

Maniphest Tasks: T13101, T4190

Differential Revision: https://secure.phabricator.com/D19193
2018-03-08 07:03:26 -08:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css When proxying an "{image ...}" image fails, show the user an error message 2018-03-08 07:03:26 -08:00
externals Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners 2018-03-07 20:57:24 -08:00
favicons Revert partial/nonfunctional OpenGraph support 2017-11-22 15:21:10 -08:00
image Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
js When proxying an "{image ...}" image fails, show the user an error message 2018-03-08 07:03:26 -08:00