mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-24 06:20:56 +01:00
6d36eb9113
Summary: Ref T12539. See PHI190. Currently, each Diff has a `revisionID`, but Revisions do not point at the current active diff. To find the active diff for a given revision, we need to issue a separate query. Furthermore, this query is inefficient for bulk loads: if we have a lot of revisions, we end up querying for all diff IDs for all those revisions first, then selecting the largest ones and querying again to get the actual diff objects. This strategy could likely be optimized but the query is a mess in any case. In several cases, it's useful to have the active diff PHID without needing to do a second query -- sometimes for convenience, and sometimes for performance. T12539 is an example of such a case: it would be nice to refine the bucketing logic (which only depends on active diff PHIDs), but it feels bad to make the page heavier to do it. For now, this is unused. I'll start using it to fix the bucketing issue, and then we can expand it gradually to address other performance/convenience issues. Test Plan: - Ran migrations, inspected database, saw sensible values. - Created a new revision, saw a sensible database value. - Updated an existing revision, saw database update properly. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T12539 Differential Revision: https://secure.phabricator.com/D18756
24 lines
571 B
PHP
24 lines
571 B
PHP
<?php
|
|
|
|
$table = new DifferentialRevision();
|
|
$conn = $table->establishConnection('w');
|
|
$diff_table = new DifferentialDiff();
|
|
|
|
foreach (new LiskMigrationIterator($table) as $revision) {
|
|
$revision_id = $revision->getID();
|
|
|
|
$diff_row = queryfx_one(
|
|
$conn,
|
|
'SELECT phid FROM %T WHERE revisionID = %d ORDER BY id DESC LIMIT 1',
|
|
$diff_table->getTableName(),
|
|
$revision_id);
|
|
|
|
if ($diff_row) {
|
|
queryfx(
|
|
$conn,
|
|
'UPDATE %T SET activeDiffPHID = %s WHERE id = %d',
|
|
$table->getTableName(),
|
|
$diff_row['phid'],
|
|
$revision_id);
|
|
}
|
|
}
|