1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00
phorge-phorge/webroot/rsrc/css
Fabian Stelzer cd677161e1 Do not CC users without permissions to view an object
Summary:
Ref T4411
I'm not quite sure if this is the right place for this as it will be difficult to provide proper user feedback of why we removed a particular subscriber.
Is the ApplicationTransactionEditor generally the right place to extract mentioned phids in comments?
On the other hand in some cases we cannot really give user feedback why a user was not subscribed (e.g.: commits & diffs)

Adding a diff to a repo where the user mentioned has no view permissions the subscriber is currently still added. Still would have to find where this is donet...

Any other places?

Unrelated: Is there any way to remove a subscriber from a commit/audit ?

Test Plan:
 - Edited tasks with the mentioned user having view permissions to this specific task and without
 - Raised concern with a commit and commented on the audit with the user having view permissions to the repo and without
 - Added a commit to a repo with and without the mentioned user having permissions
 - Mention a user in a task & commit comment with and without permissions
 - Mentioning a user in a diff description & comments with and without permissions to the specific diff

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: chad, Korvin, epriestley

Maniphest Tasks: T4411

Differential Revision: https://secure.phabricator.com/D11049
2015-01-01 08:05:52 -08:00
..
aphront Minor indentation fixes 2014-12-30 02:50:01 -08:00
application Minor indentation fixes 2014-12-30 02:50:01 -08:00
core Do not CC users without permissions to view an object 2015-01-01 08:05:52 -08:00
diviner Support WOFF files in Celerity and add Source Sans Pro 2014-03-06 11:28:24 -08:00
font Update Font Awesome .woff path 2014-11-04 14:54:51 -08:00
layout Minor indentation fixes 2014-12-30 02:50:01 -08:00
phui Minor indentation fixes 2014-12-30 02:50:01 -08:00
sprite-apps-large.css Add Phund app icon 2014-08-11 09:26:41 -07:00
sprite-apps.css Add Phund app icon 2014-08-11 09:26:41 -07:00
sprite-gradient.css Move ActionHeaders to PHUI, add ObjectBox Support, new Colors 2014-06-24 09:39:32 -07:00
sprite-login.css Add new Payment Icons 2014-10-06 13:21:29 -07:00
sprite-main-header.css Multicolor headers 2013-12-06 12:08:11 -08:00
sprite-menu.css Update message and notification icons to use fonts 2014-12-08 13:53:29 -08:00
sprite-projects.css Add an icon+background selector for project images 2013-10-17 09:32:34 -07:00
sprite-tokens.css Add Pebkac app icon, 2x Tokens 2013-11-04 11:50:19 -08:00