1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
phorge-phorge/webroot/rsrc
epriestley 9e278a89ba If a Workflow form receives a redirect response, don't re-enable the submit buttons
Summary:
See PHI488. Ref T13108. Currently, there is a narrow window between when the response returns and when the browser actually follows the redirect where the form is live and you can click the button again.

This is relativey easy if Phabricator is running //too fast// since the button may be disabled only momentarily. This seems to be easier in Firefox/Chrome than Safari.

Test Plan:
  - In Firefox and Chrome, spam-clicked a comment submit button.
    - Before: could sometimes get a double-submit.
    - After: couldn't get a double-submit.
    - This could probably be reproduced more reliabily by adding a `sleep(1)` to whatever we're redirecting //to//.
  - Submitted an empty comment, got a dialog plus a still-enabled form (so this doesn't break the non-redirect case).

Maniphest Tasks: T13108

Differential Revision: https://secure.phabricator.com/D19245
2018-03-21 11:56:21 -07:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css Add filesize limits for document rendering engines and support partial/complete rendering 2018-03-19 15:18:34 -07:00
externals If a Workflow form receives a redirect response, don't re-enable the submit buttons 2018-03-21 11:56:21 -07:00
favicons Dynamically composite favicons from customizable sources 2018-03-12 15:28:41 -07:00
image Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
js Add filesize limits for document rendering engines and support partial/complete rendering 2018-03-19 15:18:34 -07:00