1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/src
epriestley 9ea7227f0f Move workboard "View as Query" workflow to a separate controller
Summary:
Depends on D20632. Ref T4900. As with other workflows on the board controller, this one is currently in the giant main "do everything" method. Move it to a separate controller.

This makes one material improvement: previously, we built the full board and did layout on all the cards before building the query. However, we do not actually need to do this: we don't need the cards. Instead, just do layout without handing over any card PHIDs. This is slightly faster, particularly on large boards.

Test Plan:
  - Clicked "View as Query" on a board, got a query page for the column.
  - Applied a custom filter, then clicked "View as Query" on a board. Got a query page merging the two filters.
  - Applied a custom filter, then clicked "Veiw as Query" on a board, in a subproject column. Got a query page merging the two filters, respecting the project-ness of the column.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T4900

Differential Revision: https://secure.phabricator.com/D20633
2019-07-02 15:00:36 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Fix a looping workflow when trying to submit a partially-effectless transaction group 2019-05-23 19:16:17 -07:00
applications Move workboard "View as Query" workflow to a separate controller 2019-07-02 15:00:36 -07:00
docs Recommend dumping database backups with "--compress --output X" instead of "| gzip > X" 2019-06-18 11:37:14 -07:00
extensions
infrastructure Bump the remarkup cache version after JIRA/Asana rule changes 2019-06-25 14:56:29 -07:00
view Prevent editing and deleting comments in locked conversations 2019-05-23 19:04:55 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Move workboard "View as Query" workflow to a separate controller 2019-07-02 15:00:36 -07:00