1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-07 04:18:31 +01:00
phorge-phorge/src/infrastructure/markup
Joel Beales 9efcbc4ee9 Speed up loading of diffs with a lot of unit test failures
Summary:
We've been having trouble with viewing diffs timing out when there's a lot of unit test failures. It was caused by formatting userdata for every single failure. The expensive part of this was actually creating the engine for every result, so moved the construction outside of the loop.

Diffs that timed out (2 min) loading before load in around 6 seconds now.

Test Plan: Loaded diffs that used to time out. Verified that details still looked right when Show Full Unit Test Results Is Clicked.

Reviewers: epriestley, keegancsmith, lifeihuang, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran, andrewjcg

Differential Revision: https://secure.phabricator.com/D7581
2013-11-19 15:19:15 -08:00
..
interpreter Implement Graphviz, Figlet and Cowsay as Remarkup interpreter blocks 2013-10-16 19:12:14 -07:00
rule Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545. 2013-11-09 10:48:19 -08:00
PhabricatorMarkupEngine.php Speed up loading of diffs with a lot of unit test failures 2013-11-19 15:19:15 -08:00
PhabricatorMarkupInterface.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorMarkupOneOff.php Cache the computation of the custom block component of the markup key 2013-11-13 17:08:24 -08:00
PhabricatorMarkupPreviewController.php Add a "document" style to PHUIRemarkupPreviewPanel and use it in Legalpad and Phriction 2013-08-05 10:47:26 -07:00
PhabricatorSyntaxHighlighter.php Delete license headers from files 2012-11-05 11:16:51 -08:00