mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 10:22:42 +01:00
92f3ffd811
Summary:
Build the revision list table out of custom fields instead of hard-coding it, so
installs can add all sorts of zany things to it.
NOTE: You may need to implement sortFieldsForRevisionList() if you have a custom
DifferentialFieldSelector, or some fields might show up out of order.
This implementation will preserve the expected behavior:
public function sortFieldsForRevisionList(array $fields) {
$default = new DifferentialDefaultFieldSelector();
return $default->sortFieldsForRevisionList($fields);
}
Test Plan:
- Loaded differential revision list, identical to old list.
- Profiled page to verify the cost increase isn't significant (it's quite
small).
Reviewers: jungejason, btrahan
Reviewed By: btrahan
CC: aran, btrahan, davidreuss, epriestley
Maniphest Tasks: T773, T729
Differential Revision: https://secure.phabricator.com/D1388
51 lines
1.3 KiB
PHP
51 lines
1.3 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialLinesFieldSpecification
|
|
extends DifferentialFieldSpecification {
|
|
|
|
public function shouldAppearOnRevisionView() {
|
|
return true;
|
|
}
|
|
|
|
public function renderLabelForRevisionView() {
|
|
return 'Lines:';
|
|
}
|
|
|
|
public function renderValueForRevisionView() {
|
|
$diff = $this->getDiff();
|
|
return phutil_escape_html(number_format($diff->getLineCount()));
|
|
}
|
|
|
|
public function shouldAppearOnRevisionList() {
|
|
return true;
|
|
}
|
|
|
|
public function renderHeaderForRevisionList() {
|
|
return 'Lines';
|
|
}
|
|
|
|
public function getColumnClassForRevisionList() {
|
|
return 'n';
|
|
}
|
|
|
|
public function renderValueForRevisionList(DifferentialRevision $revision) {
|
|
return number_format($revision->getLineCount());
|
|
}
|
|
|
|
}
|