epriestley 9f44ee3933 Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic ... Summary: Ref T13302. In at least some browsers (including Safari and Chrome), when you write this: ``` <a href="#">...</a> ``` ...and then access `<that node>.href`, you get `http://local-domain-whatever.com/path/to/current/page#` back. This is wonderful, but not what we want. Access the raw attribute value instead, which is `#` in all browsers. Test Plan: - In Safari, Chrome, and Firefox: - Clicked "Edit Subtasks" from a task. - Clicked "Select" buttons to select several tasks. - Before: Clicking these button incorrectly closed the dialog (because of D20573). - After: Clicking these buttons now selects tasks without closing the dialog. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13302 Differential Revision: https://secure.phabricator.com/D20590		2019-06-19 10:44:42 -07:00
..
audio/basic	Add a few more sounds	2017-04-19 13:47:23 -07:00
css	Differentiate Remarkup header sizes more clearly	2019-06-04 16:03:32 -07:00
externals	Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic	2019-06-19 10:44:42 -07:00
favicons	Dynamically composite favicons from customizable sources	2018-03-12 15:28:41 -07:00
image	Render indent depth changes more clearly	2019-02-19 12:40:05 -08:00
js	Provide chart function labels over the wire instead of making them up	2019-05-22 05:22:59 -07:00