mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
a823654be0
Summary: Fixes T5646. Makes diffusion a much better user experience. Users now see a 404 exception page when they have a bad URI. Previously, they saw a developer-facing raw exception. Test Plan: played around in diffusion a bunch. most of these changes were fairly mechanical at the end of the day. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T5646 Differential Revision: https://secure.phabricator.com/D11299
74 lines
1.9 KiB
PHP
74 lines
1.9 KiB
PHP
<?php
|
|
|
|
final class DiffusionBranchTableController extends DiffusionController {
|
|
|
|
public function shouldAllowPublic() {
|
|
return true;
|
|
}
|
|
|
|
protected function processDiffusionRequest(AphrontRequest $request) {
|
|
$drequest = $this->getDiffusionRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
$repository = $drequest->getRepository();
|
|
|
|
$pager = new AphrontPagerView();
|
|
$pager->setURI($request->getRequestURI(), 'offset');
|
|
$pager->setOffset($request->getInt('offset'));
|
|
|
|
// TODO: Add support for branches that contain commit
|
|
$branches = $this->callConduitWithDiffusionRequest(
|
|
'diffusion.branchquery',
|
|
array(
|
|
'offset' => $pager->getOffset(),
|
|
'limit' => $pager->getPageSize() + 1,
|
|
));
|
|
$branches = $pager->sliceResults($branches);
|
|
|
|
$branches = DiffusionRepositoryRef::loadAllFromDictionaries($branches);
|
|
|
|
$content = null;
|
|
if (!$branches) {
|
|
$content = $this->renderStatusMessage(
|
|
pht('No Branches'),
|
|
pht('This repository has no branches.'));
|
|
} else {
|
|
$commits = id(new DiffusionCommitQuery())
|
|
->setViewer($viewer)
|
|
->withIdentifiers(mpull($branches, 'getCommitIdentifier'))
|
|
->withRepository($repository)
|
|
->execute();
|
|
|
|
$view = id(new DiffusionBranchTableView())
|
|
->setUser($viewer)
|
|
->setBranches($branches)
|
|
->setCommits($commits)
|
|
->setDiffusionRequest($drequest);
|
|
|
|
$panel = id(new AphrontPanelView())
|
|
->setNoBackground(true)
|
|
->appendChild($view)
|
|
->appendChild($pager);
|
|
|
|
$content = $panel;
|
|
}
|
|
|
|
$crumbs = $this->buildCrumbs(
|
|
array(
|
|
'branches' => true,
|
|
));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$content,
|
|
),
|
|
array(
|
|
'title' => array(
|
|
pht('Branches'),
|
|
'r'.$repository->getCallsign(),
|
|
),
|
|
));
|
|
}
|
|
|
|
}
|