1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 16:16:14 +01:00
phorge-phorge/src/applications/differential/customfield
epriestley 615d27c8e9 Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
Summary:
Depends on D19284. Ref T13110. It's now possible to get a revision into a "Abandoned + But, Never Promoted From Draft" state. Show this in the header and provide the draft hint above the comment area.

Also, remove `shouldBroadcast()`. The method `getShouldBroadcast()` now has the same meaning.

Finally, migrate existing drafts to `shouldBroadcast = false` and default `shouldBroadcast` to `true`. If we don't do this, every older revision becomes a non-broadcasting revision because this flag was not explicitly set on revision creation before, only on promotion out of draft.

Test Plan: Ran migration; abandoned draft revisions and ended up in a draft + abandoned state.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13110

Differential Revision: https://secure.phabricator.com/D19285
2018-04-03 11:09:49 -07:00
..
DifferentialAsanaRepresentationField.php Modernize remaining edge types 2015-01-03 10:58:20 +11:00
DifferentialAuditorsField.php Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
DifferentialBlameRevisionField.php Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
DifferentialBranchField.php Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
DifferentialChangesSinceLastUpdateField.php Prepare revision mail for the "Draft" status 2017-09-21 07:21:07 -07:00
DifferentialCommitsField.php Allow configuration of Differential custom fields 2014-03-11 13:01:57 -07:00
DifferentialCoreCustomField.php Fix two issues with embedding other fields inside "Summary" or "Test Plan" in Differential with the web UI 2017-01-25 13:07:30 -08:00
DifferentialCustomField.php Move many "reviewers" readers to new storage 2017-03-20 16:45:28 -07:00
DifferentialDraftField.php Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state 2018-04-03 11:09:49 -07:00
DifferentialHarbormasterField.php Fix spelling 2017-10-09 10:48:04 -07:00
DifferentialHostField.php Separate "Revision" and "Diff" fields in Differential 2015-06-16 08:53:40 -07:00
DifferentialJIRAIssuesField.php Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
DifferentialLintField.php Remove leftover code for "postponed" lint and unit status 2015-08-29 22:19:28 +10:00
DifferentialManiphestTasksField.php Simplify "Tasks" field in Differential 2016-12-16 10:26:34 -08:00
DifferentialPathField.php Separate "Revision" and "Diff" fields in Differential 2015-06-16 08:53:40 -07:00
DifferentialProjectReviewersField.php Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
DifferentialRepositoryField.php Simplify "Repository" field in Differential 2016-12-16 10:25:38 -08:00
DifferentialRequiredSignaturesField.php Replace Differential Edit controller with EditEngine-driven EditPro controller 2016-12-14 07:27:39 -08:00
DifferentialRevertPlanField.php Remove some remnants of the old ways commit mesage fields worked from Differential 2017-01-13 15:29:07 -08:00
DifferentialReviewersField.php Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
DifferentialStoredCustomField.php Use CustomFields to power Conduit auxiliary dictionaries 2014-03-11 13:02:09 -07:00
DifferentialSummaryField.php Prepare revision mail for the "Draft" status 2017-09-21 07:21:07 -07:00
DifferentialTestPlanField.php Prepare revision mail for the "Draft" status 2017-09-21 07:21:07 -07:00
DifferentialUnitField.php Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements 2018-02-12 12:18:06 -08:00