mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 18:32:41 +01:00
a035d3d528
Summary: Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here: - Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form. - Message for "project name is not unique" should be a little nicer. Same as above. - Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity. - Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions. Test Plan: - Created project. - Edited project. - Ran unit tests. - Viewed project edit history. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4379 Differential Revision: https://secure.phabricator.com/D8168
165 lines
5.1 KiB
PHP
165 lines
5.1 KiB
PHP
<?php
|
|
|
|
final class PhabricatorProjectProfileEditController
|
|
extends PhabricatorProjectController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = $data['id'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$project = id(new PhabricatorProjectQuery())
|
|
->setViewer($user)
|
|
->withIDs(array($this->id))
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->needProfiles(true)
|
|
->executeOne();
|
|
if (!$project) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$profile = $project->getProfile();
|
|
$options = PhabricatorProjectStatus::getStatusMap();
|
|
|
|
$e_name = true;
|
|
|
|
$errors = array();
|
|
if ($request->isFormPost()) {
|
|
$xactions = array();
|
|
|
|
$xactions[] = id(new PhabricatorProjectTransaction())
|
|
->setTransactionType(PhabricatorProjectTransaction::TYPE_NAME)
|
|
->setNewValue($request->getStr('name'));
|
|
|
|
$xactions[] = id(new PhabricatorProjectTransaction())
|
|
->setTransactionType(PhabricatorProjectTransaction::TYPE_STATUS)
|
|
->setNewValue($request->getStr('status'));
|
|
|
|
$xactions[] = id(new PhabricatorProjectTransaction())
|
|
->setTransactionType(PhabricatorTransactions::TYPE_VIEW_POLICY)
|
|
->setNewValue($request->getStr('can_view'));
|
|
|
|
$xactions[] = id(new PhabricatorProjectTransaction())
|
|
->setTransactionType(PhabricatorTransactions::TYPE_EDIT_POLICY)
|
|
->setNewValue($request->getStr('can_edit'));
|
|
|
|
$xactions[] = id(new PhabricatorProjectTransaction())
|
|
->setTransactionType(PhabricatorTransactions::TYPE_JOIN_POLICY)
|
|
->setNewValue($request->getStr('can_join'));
|
|
|
|
$editor = id(new PhabricatorProjectTransactionEditor())
|
|
->setActor($user)
|
|
->setContentSourceFromRequest($request)
|
|
->setContinueOnNoEffect(true)
|
|
->applyTransactions($project, $xactions);
|
|
|
|
$profile->setBlurb($request->getStr('blurb'));
|
|
|
|
if (!strlen($project->getName())) {
|
|
$e_name = pht('Required');
|
|
$errors[] = pht('Project name is required.');
|
|
} else {
|
|
$e_name = null;
|
|
}
|
|
|
|
if (!$errors) {
|
|
$project->save();
|
|
$profile->setProjectPHID($project->getPHID());
|
|
$profile->save();
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI('/project/view/'.$project->getID().'/');
|
|
}
|
|
}
|
|
|
|
$header_name = pht('Edit Project');
|
|
$title = pht('Edit Project');
|
|
$action = '/project/edit/'.$project->getID().'/';
|
|
|
|
$policies = id(new PhabricatorPolicyQuery())
|
|
->setViewer($user)
|
|
->setObject($project)
|
|
->execute();
|
|
|
|
$form = new AphrontFormView();
|
|
$form
|
|
->setID('project-edit-form')
|
|
->setUser($user)
|
|
->setAction($action)
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setLabel(pht('Name'))
|
|
->setName('name')
|
|
->setValue($project->getName())
|
|
->setError($e_name))
|
|
->appendChild(
|
|
id(new AphrontFormSelectControl())
|
|
->setLabel(pht('Project Status'))
|
|
->setName('status')
|
|
->setOptions($options)
|
|
->setValue($project->getStatus()))
|
|
->appendChild(
|
|
id(new PhabricatorRemarkupControl())
|
|
->setLabel(pht('Description'))
|
|
->setName('blurb')
|
|
->setValue($profile->getBlurb()))
|
|
->appendChild(
|
|
id(new AphrontFormPolicyControl())
|
|
->setUser($user)
|
|
->setName('can_view')
|
|
->setCaption(pht('Members can always view a project.'))
|
|
->setPolicyObject($project)
|
|
->setPolicies($policies)
|
|
->setCapability(PhabricatorPolicyCapability::CAN_VIEW))
|
|
->appendChild(
|
|
id(new AphrontFormPolicyControl())
|
|
->setUser($user)
|
|
->setName('can_edit')
|
|
->setPolicyObject($project)
|
|
->setPolicies($policies)
|
|
->setCapability(PhabricatorPolicyCapability::CAN_EDIT))
|
|
->appendChild(
|
|
id(new AphrontFormPolicyControl())
|
|
->setUser($user)
|
|
->setName('can_join')
|
|
->setCaption(
|
|
pht('Users who can edit a project can always join a project.'))
|
|
->setPolicyObject($project)
|
|
->setPolicies($policies)
|
|
->setCapability(PhabricatorPolicyCapability::CAN_JOIN))
|
|
->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->addCancelButton('/project/view/'.$project->getID().'/')
|
|
->setValue(pht('Save')));
|
|
|
|
$form_box = id(new PHUIObjectBoxView())
|
|
->setHeaderText($title)
|
|
->setFormErrors($errors)
|
|
->setForm($form);
|
|
|
|
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
|
|
->addTextCrumb(
|
|
$project->getName(),
|
|
'/project/view/'.$project->getID().'/')
|
|
->addTextCrumb(pht('Edit Project'), $this->getApplicationURI());
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$form_box,
|
|
),
|
|
array(
|
|
'title' => $title,
|
|
'device' => true,
|
|
));
|
|
}
|
|
}
|