revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion/controller
History
epriestley 0b3d10c3da Enforce sensible, unique clone/checkout names for repositories 
Summary:
Fixes T7938.

  - Primarily, users can currently shoot themselves in the foot by putting `../../etc/passwd` and other similar nonsense in these fields (this is not dangerous, but also does not work). Require sensible names.
  - Enforce uniqueness so these names can be used in URIs and as identifiers in the future.
  - (This doesn't start actually using them for anything fancy yet.)

Test Plan:
  - Gave several repositories clone names: a valid name, two duplicate names, an invalid, name, some with no names.
  - Ran migrations.
  - Got clean conversion for valid names, appropriate errors for invalid/duplicate names.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7938

Differential Revision: https://secure.phabricator.com/D14986
2016-01-11 02:06:44 -08:00
..
DiffusionBranchTableController.php Modernize tag and branch controllers in Diffusion 2016-01-05 13:58:36 -08:00
DiffusionBrowseController.php Make diffusion.filecontentquery return file PHIDs instead of raw content 2016-01-08 09:29:16 -08:00
DiffusionChangeController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionCommitBranchesController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionCommitController.php Make CommitController more flexible about handling URIs 2016-01-05 13:56:27 -08:00
DiffusionCommitEditController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionCommitTagsController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionController.php Make diffusion.filecontentquery return file PHIDs instead of raw content 2016-01-08 09:29:16 -08:00
DiffusionDiffController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionExternalController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionHistoryController.php Improve rendering of commit branching graph 2016-01-08 11:52:07 -08:00
DiffusionInlineCommentController.php Correctly clear draft markers when deleting an inline comment 2015-07-21 11:36:46 -07:00
DiffusionInlineCommentPreviewController.php Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00
DiffusionLastModifiedController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionLintController.php Modernize Diffusion lint controllers 2016-01-05 14:01:20 -08:00
DiffusionMirrorDeleteController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionMirrorEditController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionPathCompleteController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathTreeController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathValidateController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPushEventViewController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionPushLogController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushLogListController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRefTableController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRepositoryController.php Make diffusion.filecontentquery return file PHIDs instead of raw content 2016-01-08 09:29:16 -08:00
DiffusionRepositoryCreateController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryDefaultController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditActionsController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditActivateController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditAutomationController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditBasicController.php Enforce sensible, unique clone/checkout names for repositories 2016-01-11 02:06:44 -08:00
DiffusionRepositoryEditBranchesController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditController.php Fix all remaining weird Diffusion request processing 2016-01-05 14:01:53 -08:00
DiffusionRepositoryEditDangerousController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditDeleteController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditEncodingController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditHostingController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditMainController.php Enforce sensible, unique clone/checkout names for repositories 2016-01-11 02:06:44 -08:00
DiffusionRepositoryEditStagingController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditStorageController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditSubversionController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditUpdateController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryListController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRepositoryNewController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionRepositorySymbolsController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionRepositoryTestAutomationController.php Slightly modernize all Diffusion edit endpoints 2016-01-05 14:00:36 -08:00
DiffusionServeController.php Fix all remaining weird Diffusion request processing 2016-01-05 14:01:53 -08:00
DiffusionSymbolController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionTagListController.php Modernize tag and branch controllers in Diffusion 2016-01-05 13:58:36 -08:00