1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 20:22:46 +01:00
phorge-phorge/src/applications/transactions
epriestley 7593a265d5 When Herald changes object subscribers, always hide the feed story
Summary:
Fixes T8952. These feed stories are not interesting and tend to be generated as collateral damage when a non-story update is made to an old task and someone has a "subscribe me" Herald rule.

Also clean up some of the Herald field/condition indexing behavior slightly.

Test Plan: Wrote a "Subscribe X" herald rule, made a trivial update to a task. Before: low-value feed story; after: no feed story.

Maniphest Tasks: T8952

Differential Revision: https://secure.phabricator.com/D20797
2019-09-09 13:17:36 -07:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
bulk In "bin/bulk export", require "--output <path>" by default 2018-10-11 13:35:16 -07:00
commentaction When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision" 2018-11-15 20:50:21 -08:00
conduit Label transaction groups with a "group ID" so Herald can reconstruct them faithfully 2019-05-17 12:07:37 -07:00
constants Allow any transaction group to be signed with a one-shot "Sign With MFA" action 2018-12-28 00:09:30 -08:00
controller Update one straggling "CAN_INTERACT" check in comment removal 2019-07-11 16:09:52 -07:00
data Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Add "Mute/Unmute" for subscribable objects 2018-02-08 11:06:22 -08:00
editengine Fix the incorrect link target for "Create Revision" as a Menu Item 2019-04-02 15:21:59 -07:00
editfield Support "date" custom fields in "*.edit" endpoints 2019-07-31 13:10:14 -07:00
editor In Phortune, send order email to account external addresses 2019-08-26 07:48:27 -07:00
edittype Accept null via conduit.edit to unassign a task 2018-01-31 15:33:52 -08:00
engine Remove "willRenderTimeline()" from ApplicationTransactionInterface 2018-12-20 14:55:07 -08:00
engineextension Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception Raise a warning when mentioning a user in a comment on a draft revision 2018-03-12 17:03:14 -07:00
feed Separate "feed" and "notifications" better, allow stories to appear in notifications only 2018-12-10 16:02:43 -08:00
interface Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Build a rough transaction-level view of Feed 2019-05-21 12:28:00 -07:00
replyhandler Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
response Pass timeline view data to comment previews, restoring Differential comment previews 2019-01-03 13:06:54 -08:00
storage When Herald changes object subscribers, always hide the feed story 2019-09-09 13:17:36 -07:00
typeahead Support filtering feed transactions by object type 2019-05-21 12:39:10 -07:00
view Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects 2019-08-28 06:57:04 -07:00