mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-18 19:40:55 +01:00
No description
a0af5b6643
Summary: This is a followup to D228. Basically, we use "changeset" (and, implicitly, changesetID) for way too much stuff now. One thing it can't possibly capture is the complete, arbitrary mapping between the left and right sides of the displayed diff and the places we want to store the left and right side comments. This causes a bunch of bugs; basically adding inline comments is completely broken in diff-of-diff views prior to this patch. Make this mapping explicit. Note that the renderer already passes this mapping to DifferentialChangesetParser which is why there are no changes outside this file, I just didn't finish the implementation during the port. This has the nice side-effect of fixing T132 and several other bugs. Test Plan: Made new-file and old-file comments on a normal diff; reloaded page, verified comments didn't do anything crazy. Expanded text on a normal diff, made new-file and old-file comments; reloaded page, verified comments. Repeated these steps for a previous diff in the same revision; verified comments. Loaded diff-of-diffs and verified expected comments appeared. Made new left and right hand side comments, which almost work, see below. NOTE: There is still a bug where comments made in the left-display-side of a diff-of-diffs will incorrectly be written to the right-storage-side of the right-display-side diff. However, this is an issue with the JS (the PHP is correct) so I want to pull it out of scope for this patch since I think I need to fix some other JS stuff too and this improves the overall state of the world even if not everything is fixed. Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran, ola CC: aran, tuomaspelkonen, epriestley Differential Revision: 237 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. You can learn more at http://phabricator.org/ as well as click around our development install. Developer mailing list at https://groups.google.com/group/phabricator-dev and please report issues using GitHub. WHAT IS PHABRICATOR? Phabricator is a suite of web applications that facilitate software development tasks, particularly code review. The primary application in the suite is Differential, a code review tool. Phabricator is highly unstable and has many missing features! These applications are being brought over from Facebook's internal toolset, but there's a lot of stuff that hasn't made it over yet. Feel free to follow the project but you probably shouldn't try to install this yet unless you're extremely ambitious or just want to take a look at it. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0